Changeset f9b2cb4c in mainline for uspace/srv/locsrv/locsrv.c

Timestamp:

2015-08-23T12:50:23Z (9 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

9ef495f

Parents:

0dd16778

Message:

unify interface API

• introduce new interfaces
• unify location service clients to always expect service ID as the second argument
• remove obsolete methods that take explicit exchange management arguments (first phase)
• use interfaces in device drivers, devman, location service, logger, inet

File:

• uspace/srv/locsrv/locsrv.c (modified) (8 diffs)

uspace/srv/locsrv/locsrv.c

@@ -467 +467 @@
         }
         
-        /* Set the interface, if any. */
-        service->forward_interface = IPC_GET_ARG1(*icall);
-
         /* Get fqsn */
         char *fqsn;
@@ -702 +699 @@
  *
  */
-static void loc_forward(ipc_callid_t callid, ipc_call_t *call)
+static void loc_forward(ipc_callid_t callid, ipc_call_t *call, void *arg)
 {
         fibril_mutex_lock(&services_list_mutex);
@@ -709 +706 @@
          * Get ID from request
          */
+        iface_t iface = IPC_GET_ARG1(*call);
         service_id_t id = IPC_GET_ARG2(*call);
         loc_service_t *svc = loc_service_find_id(id);
@@ -719 +717 @@
         
         async_exch_t *exch = async_exchange_begin(svc->server->sess);
-        
-        if (svc->forward_interface == 0)
-                async_forward_fast(callid, exch, svc->id, 0, 0, IPC_FF_NONE);
-        else
-                async_forward_fast(callid, exch, svc->forward_interface,
-                    svc->id, 0, IPC_FF_NONE);
-        
+        async_forward_fast(callid, exch, iface, svc->id, 0, IPC_FF_NONE);
         async_exchange_end(exch);
         
@@ -1376 +1368 @@
  *
  */
-static void loc_connection_supplier(ipc_callid_t iid, ipc_call_t *icall)
+static void loc_connection_supplier(ipc_callid_t iid, ipc_call_t *icall, void *arg)
 {
         /* Accept connection */
@@ -1434 +1426 @@
  *
  */
-static void loc_connection_consumer(ipc_callid_t iid, ipc_call_t *icall)
+static void loc_connection_consumer(ipc_callid_t iid, ipc_call_t *icall, void *arg)
 {
         /* Accept connection */
@@ -1501 +1493 @@
 }
 
-/** Function for handling connections to location service
- *
- */
-static void loc_connection(ipc_callid_t iid, ipc_call_t *icall, void *arg)
-{
-        /* Select interface */
-        switch ((sysarg_t) (IPC_GET_ARG1(*icall))) {
-        case LOC_PORT_SUPPLIER:
-                loc_connection_supplier(iid, icall);
-                break;
-        case LOC_PORT_CONSUMER:
-                loc_connection_consumer(iid, icall);
-                break;
-        case LOC_CONNECT_TO_SERVICE:
-                /* Connect client to selected service */
-                loc_forward(iid, icall);
-                break;
-        default:
-                /* No such interface */
-                async_answer_0(iid, ENOENT);
-        }
-}
-
 /**
  *
@@ -1536 +1505 @@
         }
         
-        /* Set a handler of incomming connections */
-        async_set_fallback_port_handler(loc_connection, NULL);
-        
-        /* Register location service at naming service */
-        int rc = service_register(SERVICE_LOC);
+        port_id_t port;
+        int rc = async_create_port(INTERFACE_LOC_SUPPLIER,
+            loc_connection_supplier, NULL, &port);
         if (rc != EOK)
                 return rc;
         
+        rc = async_create_port(INTERFACE_LOC_CONSUMER,
+            loc_connection_consumer, NULL, &port);
+        if (rc != EOK)
+                return rc;
+        
+        /* Set a handler of incomming connections */
+        async_set_fallback_port_handler(loc_forward, NULL);
+        
+        /* Register location service at naming service */
+        rc = service_register(SERVICE_LOC);
+        if (rc != EOK)
+                return rc;
+        
         printf("%s: Accepting connections\n", NAME);
         async_manager();