Changeset ebcb05a in mainline for uspace/srv/devman/devman.c

Timestamp:

2011-04-01T19:00:51Z (14 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

969585f, ea53529

Parents:

bdbb6f6

Message:

Logging functions should append newline automatically. Since one has no
choice but to end log message with a newline, there is no need to do it
manually in every invocation.

File:

• uspace/srv/devman/devman.c (modified) (19 diffs)

uspace/srv/devman/devman.c

@@ -148 +148 @@
 
         log_msg(LVL_NOTE, "Driver `%s' was added to the list of available "
-            "drivers.\n", drv->name);
+            "drivers.", drv->name);
 }
 
@@ -238 +238 @@
 bool read_match_ids(const char *conf_path, match_id_list_t *ids)
 {
-        log_msg(LVL_DEBUG, "read_match_ids(conf_path=\"%s\")\n", conf_path);
+        log_msg(LVL_DEBUG, "read_match_ids(conf_path=\"%s\")", conf_path);
         
         bool suc = false;
@@ -248 +248 @@
         fd = open(conf_path, O_RDONLY);
         if (fd < 0) {
-                log_msg(LVL_ERROR, "Unable to open `%s' for reading: %s.\n",
+                log_msg(LVL_ERROR, "Unable to open `%s' for reading: %s.",
                     conf_path, str_error(fd));
                 goto cleanup;
@@ -257 +257 @@
         lseek(fd, 0, SEEK_SET);
         if (len == 0) {
-                log_msg(LVL_ERROR, "Configuration file '%s' is empty.\n",
+                log_msg(LVL_ERROR, "Configuration file '%s' is empty.",
                     conf_path);
                 goto cleanup;
@@ -265 +265 @@
         if (buf == NULL) {
                 log_msg(LVL_ERROR, "Memory allocation failed when parsing file "
-                    "'%s'.\n", conf_path);
+                    "'%s'.", conf_path);
                 goto cleanup;
         }
@@ -271 +271 @@
         ssize_t read_bytes = safe_read(fd, buf, len);
         if (read_bytes <= 0) {
-                log_msg(LVL_ERROR, "Unable to read file '%s'.\n", conf_path);
+                log_msg(LVL_ERROR, "Unable to read file '%s'.", conf_path);
                 goto cleanup;
         }
@@ -309 +309 @@
 bool get_driver_info(const char *base_path, const char *name, driver_t *drv)
 {
-        log_msg(LVL_DEBUG, "get_driver_info(base_path=\"%s\", name=\"%s\")\n",
+        log_msg(LVL_DEBUG, "get_driver_info(base_path=\"%s\", name=\"%s\")",
             base_path, name);
         
@@ -369 +369 @@
 int lookup_available_drivers(driver_list_t *drivers_list, const char *dir_path)
 {
-        log_msg(LVL_DEBUG, "lookup_available_drivers(dir=\"%s\")\n", dir_path);
+        log_msg(LVL_DEBUG, "lookup_available_drivers(dir=\"%s\")", dir_path);
         
         int drv_cnt = 0;
@@ -403 +403 @@
         dev_node_t *dev;
         
-        log_msg(LVL_DEBUG, "create_root_nodes()\n");
+        log_msg(LVL_DEBUG, "create_root_nodes()");
         
         fibril_rwlock_write_lock(&tree->rwlock);
@@ -488 +488 @@
 void attach_driver(dev_node_t *dev, driver_t *drv)
 {
-        log_msg(LVL_DEBUG, "attach_driver(dev=\"%s\",drv=\"%s\")\n",
+        log_msg(LVL_DEBUG, "attach_driver(dev=\"%s\",drv=\"%s\")",
             dev->pfun->pathname, drv->name);
         
@@ -511 +511 @@
         assert(fibril_mutex_is_locked(&drv->driver_mutex));
         
-        log_msg(LVL_DEBUG, "start_driver(drv=\"%s\")\n", drv->name);
+        log_msg(LVL_DEBUG, "start_driver(drv=\"%s\")", drv->name);
         
         rc = task_spawnl(NULL, drv->binary_path, drv->binary_path, NULL);
         if (rc != EOK) {
-                log_msg(LVL_ERROR, "Spawning driver `%s' (%s) failed: %s.\n",
+                log_msg(LVL_ERROR, "Spawning driver `%s' (%s) failed: %s.",
                     drv->name, drv->binary_path, str_error(rc));
                 return false;
@@ -578 +578 @@
         int phone;
 
-        log_msg(LVL_DEBUG, "pass_devices_to_driver(driver=\"%s\")\n",
+        log_msg(LVL_DEBUG, "pass_devices_to_driver(driver=\"%s\")",
             driver->name);
 
@@ -646 +646 @@
          * immediately and possibly started here as well.
          */
-        log_msg(LVL_DEBUG, "Driver `%s' enters running state.\n", driver->name);
+        log_msg(LVL_DEBUG, "Driver `%s' enters running state.", driver->name);
         driver->state = DRIVER_RUNNING;
 
@@ -663 +663 @@
 void initialize_running_driver(driver_t *driver, dev_tree_t *tree)
 {
-        log_msg(LVL_DEBUG, "initialize_running_driver(driver=\"%s\")\n",
+        log_msg(LVL_DEBUG, "initialize_running_driver(driver=\"%s\")",
             driver->name);
         
@@ -754 +754 @@
          * access any structures that would affect driver_t.
          */
-        log_msg(LVL_DEBUG, "add_device(drv=\"%s\", dev=\"%s\")\n",
+        log_msg(LVL_DEBUG, "add_device(drv=\"%s\", dev=\"%s\")",
             drv->name, dev->pfun->name);
         
@@ -816 +816 @@
         driver_t *drv = find_best_match_driver(drivers_list, dev);
         if (drv == NULL) {
-                log_msg(LVL_ERROR, "No driver found for device `%s'.\n",
+                log_msg(LVL_ERROR, "No driver found for device `%s'.",
                     dev->pfun->pathname);
                 return false;
@@ -854 +854 @@
 bool init_device_tree(dev_tree_t *tree, driver_list_t *drivers_list)
 {
-        log_msg(LVL_DEBUG, "init_device_tree()\n");
+        log_msg(LVL_DEBUG, "init_device_tree()");
         
         tree->current_handle = 0;
@@ -1033 +1033 @@
         fun->pathname = (char *) malloc(pathsize);
         if (fun->pathname == NULL) {
-                log_msg(LVL_ERROR, "Failed to allocate device path.\n");
+                log_msg(LVL_ERROR, "Failed to allocate device path.");
                 return false;
         }
@@ -1064 +1064 @@
         assert(fibril_rwlock_is_write_locked(&tree->rwlock));
         
-        log_msg(LVL_DEBUG, "insert_dev_node(dev=%p, pfun=%p [\"%s\"])\n",
+        log_msg(LVL_DEBUG, "insert_dev_node(dev=%p, pfun=%p [\"%s\"])",
             dev, pfun, pfun->pathname);