Changeset e762b43 in mainline for kernel/arch/arm32/include/atomic.h

Timestamp:

2009-03-03T16:12:43Z (16 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

02fd705

Parents:

f24d300

Message:

better inline assembler readability using the new symbolic syntax

File:

• kernel/arch/arm32/include/atomic.h (modified) (3 diffs)

kernel/arch/arm32/include/atomic.h

@@ -27 +27 @@
  */
 
-/** @addtogroup arm32   
+/** @addtogroup arm32
  * @{
  */
-/** @file 
+/** @file
  *  @brief Atomic operations.
  */
@@ -43 +43 @@
  *
  * @return Value after addition.
+ *
  */
 static inline long atomic_add(atomic_t *val, int i)
@@ -48 +49 @@
         int ret;
         volatile long *mem = &(val->count);
-
+        
         asm volatile (
-        "1:\n"
-                "ldr r2, [%1]       \n"
-                "add r3, r2, %2     \n"
-                "str r3, %0         \n"
-                "swp r3, r3, [%1]   \n"
-                "cmp r3, r2         \n"
-                "bne 1b             \n"
-
-                : "=m" (ret)
-                : "r" (mem), "r" (i)
+                "1:\n"
+                        "ldr r2, [%[mem]]\n"
+                        "add r3, r2, %[i]\n"
+                        "str r3, %[ret]\n"
+                        "swp r3, r3, [%[mem]]\n"
+                        "cmp r3, r2\n"
+                        "bne 1b\n"
+                : [ret] "=m" (ret)
+                : [mem] "r" (mem), [i] "r" (i)
                 : "r3", "r2"
         );
-
+        
         return ret;
 }