Changeset e73dbc1 in mainline for uspace/srv/net/tcp/test/pdu.c

Timestamp:

2017-08-31T23:23:55Z (8 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

1ddbf81

Parents:

94c5bc1

Message:

Add TCP unit tests for segment and seq_no modules. Fix seq_no_segment_acceptable() returning false if receive window is a strict subset of the segment.

File:

• uspace/srv/net/tcp/test/pdu.c (modified) (3 diffs)

uspace/srv/net/tcp/test/pdu.c

@@ -29 +29 @@
 #include <errno.h>
 #include <inet/endpoint.h>
+#include <mem.h>
 #include <pcut/pcut.h>
-#include <str.h>
 #include <stdlib.h>
 
+#include "main.h"
 #include "../pdu.h"
 #include "../segment.h"
-
-/** Verify that two segments have the same content */
-static void pdu_seg_cmp(tcp_segment_t *a, tcp_segment_t *b)
-{
-        PCUT_ASSERT_INT_EQUALS(a->ctrl, b->ctrl);
-        PCUT_ASSERT_INT_EQUALS(a->seq, b->seq);
-        PCUT_ASSERT_INT_EQUALS(a->ack, b->ack);
-        PCUT_ASSERT_INT_EQUALS(a->len, b->len);
-        PCUT_ASSERT_INT_EQUALS(a->wnd, b->wnd);
-        PCUT_ASSERT_INT_EQUALS(a->up, b->up);
-        PCUT_ASSERT_INT_EQUALS(tcp_segment_text_size(a),
-            tcp_segment_text_size(b));
-        if (tcp_segment_text_size(a) != 0)
-                PCUT_ASSERT_NOT_NULL(a->data);
-        if (tcp_segment_text_size(b) != 0)
-                PCUT_ASSERT_NOT_NULL(b->data);
-        if (tcp_segment_text_size(a) != 0) {
-                PCUT_ASSERT_INT_EQUALS(0, memcmp(a->data, b->data,
-                    tcp_segment_text_size(a)));
-        }
-}
 
 PCUT_INIT
@@ -86 +66 @@
         PCUT_ASSERT_INT_EQUALS(EOK, rc);
 
-        pdu_seg_cmp(seg, dseg);
+        test_seg_same(seg, dseg);
         tcp_segment_delete(seg);
 }
@@ -124 +104 @@
         PCUT_ASSERT_INT_EQUALS(EOK, rc);
 
-        pdu_seg_cmp(seg, dseg);
+        test_seg_same(seg, dseg);
         tcp_segment_delete(seg);
         free(data);