Changeset e3272101 in mainline for uspace/lib/c/test/imath.c

Timestamp:

2019-02-11T14:08:52Z (6 years ago)

Author:

Matthieu Riolo <matthieu.riolo@…>

Children:

d5a89a3

Parents:

aa57bf7

Message:

make ilog10_u64() return an errno_t

The function ilog10_u64() used to return 0
for the value 0. Which is not correct. Either
NaN or -Infinity are correct, but not 0, since
it would be ambiguous with log(1). To ensure this
case the function ilog10_u64() has been changed
to return a errno_t indicating a failure.

File:

• uspace/lib/c/test/imath.c (modified) (1 diff)

uspace/lib/c/test/imath.c

@@ -78 +78 @@
 PCUT_TEST(ilog10_u64_zero)
 {
-        unsigned ret = ilog10_u64(0);
-        PCUT_ASSERT_INT_EQUALS(0, ret);
+        unsigned res;
+        errno_t ret = ilog10_u64(0, &res);
+        PCUT_ASSERT_ERRNO_VAL(ERANGE, ret);
 }
 
 PCUT_TEST(ilog10_u64_one)
 {
-        unsigned ret = ilog10_u64(1);
-        PCUT_ASSERT_INT_EQUALS(0, ret);
+        unsigned res;
+        errno_t ret = ilog10_u64(1, &res);
+        PCUT_ASSERT_ERRNO_VAL(EOK, ret);
+        PCUT_ASSERT_INT_EQUALS(0, res);
 }
 
 PCUT_TEST(ilog10_u64_max)
 {
-        unsigned ret = ilog10_u64(MAX_NUM);
-        PCUT_ASSERT_INT_EQUALS(MAX_EXP, ret);
+        unsigned res;
+        errno_t ret = ilog10_u64(MAX_NUM, &res);
+        PCUT_ASSERT_ERRNO_VAL(EOK, ret);
+        PCUT_ASSERT_INT_EQUALS(MAX_EXP, res);
 }