Changeset e2650d3 in mainline for kernel/generic/src/mm/frame.c

Timestamp:

2010-07-20T13:53:36Z (15 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

4738d84

Parents:

4d0f97d

Message:

rename PA_overlaps to PA_OVERLAPS
be more tolerant about some cases of overlapping zones (when it is actually not an issue)

File:

• kernel/generic/src/mm/frame.c (modified) (4 diffs)

kernel/generic/src/mm/frame.c

@@ -121 +121 @@
  *
  */
-NO_TRACE static size_t zones_insert_zone(pfn_t base, size_t count)
+NO_TRACE static size_t zones_insert_zone(pfn_t base, size_t count,
+    zone_flags_t flags)
 {
         if (zones.count + 1 == ZONES_MAX) {
@@ -131 +132 @@
         for (i = 0; i < zones.count; i++) {
                 /* Check for overlap */
-                if (overlaps(base, count,
-                    zones.info[i].base, zones.info[i].count)) {
-                        printf("Zone (%p, %p) overlaps with zone (%p, %p)!\n",
-                            PFN2ADDR(base), PFN2ADDR(base + count),
-                            PFN2ADDR(zones.info[i].base),
-                            PFN2ADDR(zones.info[i].base + zones.info[i].count));
+                if (overlaps(zones.info[i].base, zones.info[i].count,
+                    base, count)) {
+                        
+                        /*
+                         * If the overlaping zones are of the same type
+                         * and the new zone is completely within the previous
+                         * one, then quietly ignore the new zone.
+                         *
+                         */
+                        
+                        if ((zones.info[i].flags != flags) ||
+                            (!iswithin(zones.info[i].base, zones.info[i].count,
+                            base, count))) {
+                                printf("Zone (%p, %p) overlaps with previous zone (%p, %p)!\n",
+                                    PFN2ADDR(base), PFN2ADDR(count),
+                                    PFN2ADDR(zones.info[i].base),
+                                    PFN2ADDR(zones.info[i].count));
+                        }
+                        
                         return (size_t) -1;
                 }
@@ -898 +912 @@
                 }
                 
-                size_t znum = zones_insert_zone(start, count);
+                size_t znum = zones_insert_zone(start, count, flags);
                 if (znum == (size_t) -1) {
                         irq_spinlock_unlock(&zones.lock, true);
@@ -921 +935 @@
         
         /* Non-available zone */
-        size_t znum = zones_insert_zone(start, count);
+        size_t znum = zones_insert_zone(start, count, flags);
         if (znum == (size_t) -1) {
                 irq_spinlock_unlock(&zones.lock, true);