Changeset e247d83 in mainline for uspace/drv/uhci-hcd/transfer_list.c

Timestamp:

2011-05-23T14:04:51Z (14 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

563ead9

Parents:

8953514

Message:

Const, type-casting and other minor fixes

File:

• uspace/drv/uhci-hcd/transfer_list.c (modified) (5 diffs)

uspace/drv/uhci-hcd/transfer_list.c

@@ -58 +58 @@
                 return ENOMEM;
         }
-        uint32_t queue_head_pa = addr_to_phys(instance->queue_head);
+        const uint32_t queue_head_pa = addr_to_phys(instance->queue_head);
         usb_log_debug2("Transfer list %s setup with QH: %p (%#" PRIx32" ).\n",
             name, instance->queue_head, queue_head_pa);
@@ -90 +90 @@
 {
         assert(instance);
+        assert(instance->queue_head);
         assert(next);
-        if (!instance->queue_head)
-                return;
         /* Set queue_head.next to point to the follower */
         qh_set_next_qh(instance->queue_head, next->queue_head);
@@ -137 +136 @@
         write_barrier();
 
-        /* Add to the driver list */
+        /* Add to the driver's list */
         list_append(&batch->link, &instance->batch_list);
 
@@ -160 +159 @@
         link_t *current = instance->batch_list.next;
         while (current != &instance->batch_list) {
-                link_t *next = current->next;
+                link_t * const next = current->next;
                 usb_transfer_batch_t *batch =
                     usb_transfer_batch_from_link(current);
@@ -182 +181 @@
         fibril_mutex_lock(&instance->guard);
         while (!list_empty(&instance->batch_list)) {
-                link_t *current = instance->batch_list.next;
+                link_t * const current = instance->batch_list.next;
                 usb_transfer_batch_t *batch =
                     usb_transfer_batch_from_link(current);