Changeset da1bafb in mainline for kernel/genarch/src/mm/as_ht.c

Timestamp:

2010-05-24T18:57:31Z (15 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0095368

Parents:

666f492

Message:

major code revision

• replace spinlocks taken with interrupts disabled with irq_spinlocks
• change spacing (not indendation) to be tab-size independent
• use unsigned integer types where appropriate (especially bit flags)
• visual separation
• remove argument names in function prototypes
• string changes
• correct some formating directives
• replace various cryptic single-character variables (t, a, m, c, b, etc.) with proper identifiers (thread, task, timeout, as, itm, itc, etc.)
• unify some assembler constructs
• unused page table levels are now optimized out in compile time
• replace several ints (with boolean semantics) with bools
• use specifically sized types instead of generic types where appropriate (size_t, uint32_t, btree_key_t)
• improve comments
• split asserts with conjuction into multiple independent asserts

File:

• kernel/genarch/src/mm/as_ht.c (modified) (8 diffs)

kernel/genarch/src/mm/as_ht.c

@@ -30 +30 @@
  * @{
  */
- 
+
 /**
  * @file
- * @brief       Address space functions for global page hash table.
+ * @brief Address space functions for global page hash table.
  */
 
@@ -46 +46 @@
 #include <synch/mutex.h>
 
-static pte_t *ht_create(int flags);
-static void ht_destroy(pte_t *page_table);
+static pte_t *ht_create(unsigned int);
+static void ht_destroy(pte_t *);
 
-static void ht_lock(as_t *as, bool lock);
-static void ht_unlock(as_t *as, bool unlock);
+static void ht_lock(as_t *, bool);
+static void ht_unlock(as_t *, bool);
 
 as_operations_t as_ht_operations = {
@@ -68 +68 @@
  *
  * @return Returns NULL.
+ *
  */
-pte_t *ht_create(int flags)
+pte_t *ht_create(unsigned int flags)
 {
         if (flags & FLAG_AS_KERNEL) {
@@ -75 +76 @@
                 mutex_initialize(&page_ht_lock, MUTEX_PASSIVE);
         }
+        
         return NULL;
 }
@@ -83 +85 @@
  *
  * @param page_table This parameter is ignored.
+ *
  */
 void ht_destroy(pte_t *page_table)
@@ -94 +97 @@
  * Interrupts must be disabled.
  *
- * @param as Address space.
+ * @param as   Address space.
  * @param lock If false, do not attempt to lock the address space.
+ *
  */
 void ht_lock(as_t *as, bool lock)
@@ -101 +105 @@
         if (lock)
                 mutex_lock(&as->lock);
+        
         mutex_lock(&page_ht_lock);
 }
@@ -109 +114 @@
  * Interrupts must be disabled.
  *
- * @param as Address space.
+ * @param as     Address space.
  * @param unlock If false, do not attempt to lock the address space.
+ *
  */
 void ht_unlock(as_t *as, bool unlock)
 {
         mutex_unlock(&page_ht_lock);
+        
         if (unlock)
                 mutex_unlock(&as->lock);