Changeset d5c1051 in mainline for uspace/app/trace/trace.c

Timestamp:

2017-12-20T22:25:34Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

39b54fe

Parents:

8610c2c

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2017-12-20 22:22:29)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2017-12-20 22:25:34)

Message:

"Obviously harmless" error handling tweaks.

File:

• uspace/app/trace/trace.c (modified) (9 diffs)

uspace/app/trace/trace.c

@@ -162 +162 @@
         
         int rc = udebug_begin(ksess);
-        if (rc < 0) {
+        if (rc != EOK) {
                 printf("udebug_begin() -> %s\n", str_error_name(rc));
                 return rc;
@@ -168 +168 @@
         
         rc = udebug_set_evmask(ksess, UDEBUG_EM_ALL);
-        if (rc < 0) {
+        if (rc != EOK) {
                 printf("udebug_set_evmask(0x%x) -> %s\n ", UDEBUG_EM_ALL, str_error_name(rc));
                 return rc;
@@ -186 +186 @@
         rc = udebug_thread_read(sess, thread_hash_buf,
                 THBUF_SIZE*sizeof(unsigned), &tb_copied, &tb_needed);
-        if (rc < 0) {
+        if (rc != EOK) {
                 printf("udebug_thread_read() -> %s\n", str_error_name(rc));
                 return rc;
@@ -325 +325 @@
         rc = udebug_mem_read(sess, &call, sc_args[0], sizeof(call));
         
-        if (rc >= 0)
+        if (rc == EOK)
                 ipcp_call_in(&call, sc_rc);
 }
@@ -338 +338 @@
         rc = udebug_args_read(sess, thread_hash, sc_args);
 
-        if (rc < 0) {
+        if (rc != EOK) {
                 printf("error\n");
                 return;
@@ -368 +368 @@
 //      printf("[%d] ", thread_id);
 
-        if (rc < 0) {
+        if (rc != EOK) {
                 printf("error\n");
                 return;
@@ -445 +445 @@
                 }
 
-                if (rc >= 0) {
+                if (rc == EOK) {
                         switch (ev_type) {
                         case UDEBUG_EVENT_SYSCALL_B:
@@ -603 +603 @@
 
         rc = get_thread_list();
-        if (rc < 0) {
+        if (rc != EOK) {
                 printf("Failed to get thread list (%s)\n", str_error(rc));
                 return;
@@ -859 +859 @@
 
         rc = connect_task(task_id);
-        if (rc < 0) {
+        if (rc != EOK) {
                 printf("Failed connecting to task %" PRIu64 ".\n", task_id);
                 return 1;