Changeset cd3b380 in mainline for kernel/arch/sparc64/src/mm/sun4u/as.c

Timestamp:

2013-09-11T11:56:39Z (12 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

1db5669

Parents:

43dd8028

Message:

due to the removal of FRAME_KA, the return value of frame_alloc*() needs to be checked before converting the physical address to kernel address

File:

• kernel/arch/sparc64/src/mm/sun4u/as.c (modified) (1 diff)

kernel/arch/sparc64/src/mm/sun4u/as.c

@@ -63 +63 @@
 {
 #ifdef CONFIG_TSB
+        uintptr_t tsb_phys =
+            frame_alloc(SIZE2FRAMES((ITSB_ENTRY_COUNT + DTSB_ENTRY_COUNT) *
+            sizeof(tsb_entry_t)), flags, 0);
+        if (!tsb_phys)
+                return -1;
+        
+        tsb_entry_t *tsb = (tsb_entry_t *) PA2KA(tsb_phys);
+        
+        as->arch.itsb = tsb;
+        as->arch.dtsb = tsb + ITSB_ENTRY_COUNT;
+        
+        memsetb(as->arch.itsb, (ITSB_ENTRY_COUNT + DTSB_ENTRY_COUNT) *
+            sizeof(tsb_entry_t), 0);
+#endif
+        
+        return 0;
+}
+
+int as_destructor_arch(as_t *as)
+{
+#ifdef CONFIG_TSB
         size_t frames = SIZE2FRAMES((ITSB_ENTRY_COUNT + DTSB_ENTRY_COUNT) *
             sizeof(tsb_entry_t));
-        
-        uintptr_t tsb = PA2KA(frame_alloc(frames, flags, 0));
-        if (!tsb)
-                return -1;
-        
-        as->arch.itsb = (tsb_entry_t *) tsb;
-        as->arch.dtsb = (tsb_entry_t *) (tsb +
-            ITSB_ENTRY_COUNT * sizeof(tsb_entry_t));
-        
-        memsetb(as->arch.itsb,
-            (ITSB_ENTRY_COUNT + DTSB_ENTRY_COUNT) * sizeof(tsb_entry_t), 0);
-#endif
-        
-        return 0;
-}
-
-int as_destructor_arch(as_t *as)
-{
-#ifdef CONFIG_TSB
-        /*
-         * The count must be calculated with respect to the emualted 16K page
-         * size.
-         */
-        size_t cnt = ((ITSB_ENTRY_COUNT + DTSB_ENTRY_COUNT) *
-            sizeof(tsb_entry_t)) >> FRAME_WIDTH;
-        frame_free(KA2PA((uintptr_t) as->arch.itsb));
-        
-        return cnt;
+        frame_free(KA2PA((uintptr_t) as->arch.itsb), frames);
+        
+        return frames;
 #else
         return 0;