Changeset ca48672 in mainline for uspace/lib/drv/generic/driver.c

Timestamp:

2025-06-20T15:18:27Z (32 hours ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

master

Children:

cb20b05

Parents:

3951046

Message:

loc_service_register() needs to take a port ID argument.

File:

• uspace/lib/drv/generic/driver.c (modified) (5 diffs)

uspace/lib/drv/generic/driver.c

@@ -1046 +1046 @@
 errno_t ddf_driver_main(const driver_t *drv)
 {
+        port_id_t drv_port;
+        port_id_t devman_port;
+
         /*
          * Remember the driver structure - driver_ops will be called by generic
@@ -1056 +1059 @@
          * incoming connections.
          */
-        port_id_t port;
-        errno_t rc = async_create_port(INTERFACE_DDF_DRIVER, driver_connection_driver,
-            NULL, &port);
+        errno_t rc = async_create_port(INTERFACE_DDF_DRIVER,
+            driver_connection_driver, NULL, &drv_port);
         if (rc != EOK) {
                 printf("Error: Failed to create driver port.\n");
@@ -1065 +1067 @@
 
         rc = async_create_port(INTERFACE_DDF_DEVMAN, driver_connection_devman,
-            NULL, &port);
+            NULL, &devman_port);
         if (rc != EOK) {
                 printf("Error: Failed to create devman port.\n");
+                async_port_destroy(drv_port);
                 return rc;
         }
@@ -1078 +1081 @@
                     "(%s).\n", (rc == EEXIST) ? "driver already started" :
                     str_error(rc));
-
+                async_port_destroy(devman_port);
+                async_port_destroy(drv_port);
                 return rc;
         }
@@ -1086 +1090 @@
         if (rc != EOK) {
                 printf("Error: Failed returning task value.\n");
+                // XXX devman_driver_unregister
+                async_port_destroy(devman_port);
+                async_port_destroy(drv_port);
                 return rc;
         }