Changeset c7f8fc5 in mainline

Timestamp:

2012-01-13T22:31:32Z (13 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

d56382d

Parents:

c142860

Message:

Use temporary pages in the ELF backend.

File:

• kernel/generic/src/mm/backend_elf.c (modified) (12 diffs)

kernel/generic/src/mm/backend_elf.c

@@ -44 +44 @@
 #include <mm/page.h>
 #include <mm/reserve.h>
+#include <mm/km.h>
 #include <genarch/mm/page_pt.h>
 #include <genarch/mm/page_ht.h>
@@ -229 +230 @@
         elf_segment_header_t *entry = area->backend_data.segment;
         btree_node_t *leaf;
-        uintptr_t base, frame, page, start_anon;
+        uintptr_t base;
+        uintptr_t frame;
+        uintptr_t kpage;
+        uintptr_t upage;
+        uintptr_t start_anon;
         size_t i;
         bool dirty = false;
@@ -249 +254 @@
             (((void *) elf) + ALIGN_DOWN(entry->p_offset, PAGE_SIZE));
 
-        /* Virtual address of faulting page*/
-        page = ALIGN_DOWN(addr, PAGE_SIZE);
+        /* Virtual address of faulting page */
+        upage = ALIGN_DOWN(addr, PAGE_SIZE);
 
         /* Virtual address of the end of initialized part of segment */
@@ -264 +269 @@
                 mutex_lock(&area->sh_info->lock);
                 frame = (uintptr_t) btree_search(&area->sh_info->pagemap,
-                    page - area->base, &leaf);
+                    upage - area->base, &leaf);
                 if (!frame) {
                         unsigned int i;
@@ -273 +278 @@
 
                         for (i = 0; i < leaf->keys; i++) {
-                                if (leaf->key[i] == page - area->base) {
+                                if (leaf->key[i] == upage - area->base) {
                                         found = true;
                                         break;
@@ -281 +286 @@
                 if (frame || found) {
                         frame_reference_add(ADDR2PFN(frame));
-                        page_mapping_insert(AS, addr, frame,
+                        page_mapping_insert(AS, upage, frame,
                             as_area_get_flags(area));
-                        if (!used_space_insert(area, page, 1))
+                        if (!used_space_insert(area, upage, 1))
                                 panic("Cannot insert used space.");
                         mutex_unlock(&area->sh_info->lock);
@@ -294 +299 @@
          * mapping.
          */
-        if (page >= entry->p_vaddr && page + PAGE_SIZE <= start_anon) {
+        if (upage >= entry->p_vaddr && upage + PAGE_SIZE <= start_anon) {
                 /*
                  * Initialized portion of the segment. The memory is backed
@@ -304 +309 @@
                  */
                 if (entry->p_flags & PF_W) {
-                        frame = (uintptr_t)frame_alloc_noreserve(ONE_FRAME, 0);
-                        memcpy((void *) PA2KA(frame),
-                            (void *) (base + i * FRAME_SIZE), FRAME_SIZE);
-                        if (entry->p_flags & PF_X) {
-                                smc_coherence_block((void *) PA2KA(frame),
-                                    FRAME_SIZE);
-                        }
+                        kpage = km_temporary_page_get(&frame, FRAME_NO_RESERVE);
+                        memcpy((void *) kpage, (void *) (base + i * FRAME_SIZE),
+                            PAGE_SIZE);
+                        if (entry->p_flags & PF_X)
+                                smc_coherence_block((void *) kpage, FRAME_SIZE);
+                        km_temporary_page_put(kpage);
                         dirty = true;
                 } else {
                         frame = KA2PA(base + i * FRAME_SIZE);
                 }       
-        } else if (page >= start_anon) {
+        } else if (upage >= start_anon) {
                 /*
                  * This is the uninitialized portion of the segment.
@@ -322 +326 @@
                  * and cleared.
                  */
-                frame = (uintptr_t) frame_alloc_noreserve(ONE_FRAME, 0);
-                memsetb((void *) PA2KA(frame), FRAME_SIZE, 0);
+                kpage = km_temporary_page_get(&frame, FRAME_NO_RESERVE);
+                memsetb((void *) kpage, PAGE_SIZE, 0);
+                km_temporary_page_put(kpage);
                 dirty = true;
         } else {
@@ -334 +339 @@
                  * (The segment can be and often is shorter than 1 page).
                  */
-                if (page < entry->p_vaddr)
-                        pad_lo = entry->p_vaddr - page;
+                if (upage < entry->p_vaddr)
+                        pad_lo = entry->p_vaddr - upage;
                 else
                         pad_lo = 0;
 
-                if (start_anon < page + PAGE_SIZE)
-                        pad_hi = page + PAGE_SIZE - start_anon;
+                if (start_anon < upage + PAGE_SIZE)
+                        pad_hi = upage + PAGE_SIZE - start_anon;
                 else
                         pad_hi = 0;
 
-                frame = (uintptr_t) frame_alloc_noreserve(ONE_FRAME, 0);
-                memcpy((void *) (PA2KA(frame) + pad_lo),
-                    (void *) (base + i * FRAME_SIZE + pad_lo),
-                    FRAME_SIZE - pad_lo - pad_hi);
+                kpage = km_temporary_page_get(&frame, FRAME_NO_RESERVE);
+                memcpy((void *) (kpage + pad_lo),
+                    (void *) (base + i * PAGE_SIZE + pad_lo),
+                    PAGE_SIZE - pad_lo - pad_hi);
                 if (entry->p_flags & PF_X) {
-                        smc_coherence_block((void *) (PA2KA(frame) + pad_lo), 
-                            FRAME_SIZE - pad_lo - pad_hi);
+                        smc_coherence_block((void *) (kpage + pad_lo), 
+                            PAGE_SIZE - pad_lo - pad_hi);
                 }
-                memsetb((void *) PA2KA(frame), pad_lo, 0);
-                memsetb((void *) (PA2KA(frame) + FRAME_SIZE - pad_hi), pad_hi,
-                    0);
+                memsetb((void *) kpage, pad_lo, 0);
+                memsetb((void *) (kpage + PAGE_SIZE - pad_hi), pad_hi, 0);
+                km_temporary_page_put(kpage);
                 dirty = true;
         }
@@ -360 +365 @@
         if (dirty && area->sh_info) {
                 frame_reference_add(ADDR2PFN(frame));
-                btree_insert(&area->sh_info->pagemap, page - area->base,
+                btree_insert(&area->sh_info->pagemap, upage - area->base,
                     (void *) frame, leaf);
         }
@@ -367 +372 @@
                 mutex_unlock(&area->sh_info->lock);
 
-        page_mapping_insert(AS, addr, frame, as_area_get_flags(area));
-        if (!used_space_insert(area, page, 1))
+        page_mapping_insert(AS, upage, frame, as_area_get_flags(area));
+        if (!used_space_insert(area, upage, 1))
                 panic("Cannot insert used space.");