Changeset c77cfd8 in mainline for uspace/app/taskbar/types/clock.h

Timestamp:

2022-10-04T19:55:25Z (3 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

master, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

e0e612b

Parents:

3fd38b2

Message:

Proper timer cleanup, unit tests

Destroying a timer that sets itself again (i.e., runs periodically) is
a little tricky. It requires a handshake (similar to destroying a worker
thread). Realizing that this handshake works correctly is a little bit
mind boggling.

File:

• uspace/app/taskbar/types/clock.h (modified) (1 diff)

uspace/app/taskbar/types/clock.h

@@ -55 +55 @@
         gfx_rect_t rect;
 
+        /** Clock lock */
+        fibril_mutex_t lock;
+
         /** Clock update timer */
         fibril_timer_t *timer;
+
+        /** Signal to timer that we are cleaning up */
+        bool timer_cleanup;
+
+        /** Signal to maih thread that timer is done */
+        bool timer_done;
+
+        /** Timer done condition variable */
+        fibril_condvar_t timer_done_cv;
 } taskbar_clock_t;