Changeset c280d7e in mainline for uspace/lib/usbdev/src/pipes.c

Timestamp:

2018-01-20T03:02:36Z (7 years ago)

Author:

Ondřej Hlavatý <aearsis@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

60d3f35

Parents:

3cdaa7f

git-author:

Ondřej Hlavatý <aearsis@…> (2018-01-20 03:02:32)

git-committer:

Ondřej Hlavatý <aearsis@…> (2018-01-20 03:02:36)

Message:

libdrv: usb iface callbacks joined

In addition to handle and current interface, it is good for the device
to know its address and speed. Also, it is expected to add some other
fields (stats, info tied to devices of specific speed and so on) in the
future. Instead of adding yet another call, join those two and let HC
fill a description structure.

File:

• uspace/lib/usbdev/src/pipes.c (modified) (1 diff)

uspace/lib/usbdev/src/pipes.c

@@ -248 +248 @@
  */
 static int usb_isoch_session_initialize(usb_pipe_t *pipe) {
-        devman_handle_t handle;
-
-        async_exch_t *exch = async_exchange_begin(pipe->bus_session);
-        if (!exch)
-                return EPARTY;
-
-        int ret = usb_get_my_device_handle(exch, &handle);
-
-        async_exchange_end(exch);
-        if (ret != EOK)
-                return ret;
-
-        pipe->isoch_session = usb_dev_connect(handle);
-        if (!pipe->isoch_session)
-                return ENAK;
-
+
+        /*
+         * XXX: As parallel exhanges are implemented by using parallel sessions,
+         * it is safe to just take the same session. Once this won't be true,
+         * just use session cloning to clone the bus session.
+         */
+        pipe->isoch_session = pipe->bus_session;
         return EOK;
 }