Changeset b7fd2a0 in mainline for uspace/srv/net/ethip/pdu.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/net/ethip/pdu.c (modified) (4 diffs)

uspace/srv/net/ethip/pdu.c

@@ -47 +47 @@
 
 /** Encode Ethernet PDU. */
-int eth_pdu_encode(eth_frame_t *frame, void **rdata, size_t *rsize)
+errno_t eth_pdu_encode(eth_frame_t *frame, void **rdata, size_t *rsize)
 {
         void *data;
@@ -75 +75 @@
 
 /** Decode Ethernet PDU. */
-int eth_pdu_decode(void *data, size_t size, eth_frame_t *frame)
+errno_t eth_pdu_decode(void *data, size_t size, eth_frame_t *frame)
 {
         eth_header_t *hdr;
@@ -106 +106 @@
 
 /** Encode ARP PDU. */
-int arp_pdu_encode(arp_eth_packet_t *packet, void **rdata, size_t *rsize)
+errno_t arp_pdu_encode(arp_eth_packet_t *packet, void **rdata, size_t *rsize)
 {
         void *data;
@@ -149 +149 @@
 
 /** Decode ARP PDU. */
-int arp_pdu_decode(void *data, size_t size, arp_eth_packet_t *packet)
+errno_t arp_pdu_decode(void *data, size_t size, arp_eth_packet_t *packet)
 {
         arp_eth_packet_fmt_t *pfmt;