Changeset b7fd2a0 in mainline for uspace/srv/net/ethip/arp.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/net/ethip/arp.c (modified) (5 diffs)

uspace/srv/net/ethip/arp.c

@@ -50 +50 @@
 #define ARP_REQUEST_TIMEOUT (3 * 1000 * 1000)
 
-static int arp_send_packet(ethip_nic_t *nic, arp_eth_packet_t *packet);
+static errno_t arp_send_packet(ethip_nic_t *nic, arp_eth_packet_t *packet);
 
 void arp_received(ethip_nic_t *nic, eth_frame_t *frame)
@@ -57 +57 @@
         
         arp_eth_packet_t packet;
-        int rc = arp_pdu_decode(frame->data, frame->size, &packet);
+        errno_t rc = arp_pdu_decode(frame->data, frame->size, &packet);
         if (rc != EOK)
                 return;
@@ -94 +94 @@
 }
 
-int arp_translate(ethip_nic_t *nic, addr32_t src_addr, addr32_t ip_addr,
+errno_t arp_translate(ethip_nic_t *nic, addr32_t src_addr, addr32_t ip_addr,
     addr48_t mac_addr)
 {
@@ -103 +103 @@
         }
 
-        int rc = atrans_lookup(ip_addr, mac_addr);
+        errno_t rc = atrans_lookup(ip_addr, mac_addr);
         if (rc == EOK)
                 return EOK;
@@ -122 +122 @@
 }
 
-static int arp_send_packet(ethip_nic_t *nic, arp_eth_packet_t *packet)
+static errno_t arp_send_packet(ethip_nic_t *nic, arp_eth_packet_t *packet)
 {
-        int rc;
+        errno_t rc;
         void *pdata;
         size_t psize;