Changeset b7fd2a0 in mainline for uspace/srv/hw/char/s3c24xx_uart/s3c24xx_uart.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/hw/char/s3c24xx_uart/s3c24xx_uart.c (modified) (6 diffs)

uspace/srv/hw/char/s3c24xx_uart/s3c24xx_uart.c

@@ -69 +69 @@
 static void s3c24xx_uart_sendb(s3c24xx_uart_t *, uint8_t);
 
-static int s3c24xx_uart_read(chardev_srv_t *, void *, size_t, size_t *);
-static int s3c24xx_uart_write(chardev_srv_t *, const void *, size_t, size_t *);
+static errno_t s3c24xx_uart_read(chardev_srv_t *, void *, size_t, size_t *);
+static errno_t s3c24xx_uart_write(chardev_srv_t *, const void *, size_t, size_t *);
 
 static chardev_ops_t s3c24xx_uart_chardev_ops = {
@@ -82 +82 @@
         
         async_set_fallback_port_handler(s3c24xx_uart_connection, uart);
-        int rc = loc_server_register(NAME);
+        errno_t rc = loc_server_register(NAME);
         if (rc != EOK) {
                 printf("%s: Unable to register server.\n", NAME);
@@ -124 +124 @@
 static void s3c24xx_uart_irq_handler(ipc_call_t *call, void *arg)
 {
-        int rc;
+        errno_t rc;
 
         (void) call;
@@ -200 +200 @@
 }
 
-static int s3c24xx_uart_read(chardev_srv_t *srv, void *buf, size_t size,
+static errno_t s3c24xx_uart_read(chardev_srv_t *srv, void *buf, size_t size,
     size_t *nread)
 {
@@ -206 +206 @@
         size_t p;
         uint8_t *bp = (uint8_t *) buf;
-        int rc;
+        errno_t rc;
 
         fibril_mutex_lock(&uart->buf_lock);
@@ -227 +227 @@
 }
 
-static int s3c24xx_uart_write(chardev_srv_t *srv, const void *data, size_t size,
+static errno_t s3c24xx_uart_write(chardev_srv_t *srv, const void *data, size_t size,
     size_t *nwr)
 {