Changeset b7fd2a0 in mainline for uspace/srv/hid/remcons/user.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/hid/remcons/user.c (modified) (6 diffs)

uspace/srv/hid/remcons/user.c

@@ -187 +187 @@
  * might be negative.
  */
-static int telnet_user_recv_next_byte_no_lock(telnet_user_t *user, char *byte)
+static errno_t telnet_user_recv_next_byte_no_lock(telnet_user_t *user, char *byte)
 {
         /* No more buffered data? */
         if (user->socket_buffer_len <= user->socket_buffer_pos) {
-                int rc;
+                errno_t rc;
                 size_t recv_length;
 
@@ -272 +272 @@
  * @return Error code.
  */
-int telnet_user_get_next_keyboard_event(telnet_user_t *user, kbd_event_t *event)
+errno_t telnet_user_get_next_keyboard_event(telnet_user_t *user, kbd_event_t *event)
 {
         fibril_mutex_lock(&user->guard);
@@ -283 +283 @@
                 /* Skip zeros, bail-out on error. */
                 while (next_byte == 0) {
-                        int rc = telnet_user_recv_next_byte_no_lock(user, &next_byte);
+                        errno_t rc = telnet_user_recv_next_byte_no_lock(user, &next_byte);
                         if (rc != EOK) {
                                 fibril_mutex_unlock(&user->guard);
@@ -339 +339 @@
  * @param size Size of @p data buffer in bytes.
  */
-static int telnet_user_send_data_no_lock(telnet_user_t *user, uint8_t *data, size_t size)
+static errno_t telnet_user_send_data_no_lock(telnet_user_t *user, uint8_t *data, size_t size)
 {
         uint8_t *converted = malloc(3 * size + 1);
@@ -362 +362 @@
 
 
-        int rc = tcp_conn_send(user->conn, converted, converted_size);
+        errno_t rc = tcp_conn_send(user->conn, converted, converted_size);
         free(converted);
 
@@ -374 +374 @@
  * @param size Size of @p data buffer in bytes.
  */
-int telnet_user_send_data(telnet_user_t *user, uint8_t *data, size_t size)
+errno_t telnet_user_send_data(telnet_user_t *user, uint8_t *data, size_t size)
 {
         fibril_mutex_lock(&user->guard);
 
-        int rc = telnet_user_send_data_no_lock(user, data, size);
+        errno_t rc = telnet_user_send_data_no_lock(user, data, size);
 
         fibril_mutex_unlock(&user->guard);