Changeset b7fd2a0 in mainline for uspace/lib/clui/tinput.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/clui/tinput.c (modified) (6 diffs)

uspace/lib/clui/tinput.c

@@ -185 +185 @@
 }
 
-static int tinput_display(tinput_t *ti)
+static errno_t tinput_display(tinput_t *ti)
 {
         sysarg_t col0, row0;
@@ -542 +542 @@
 {
         char *str;
-        int rc = clipboard_get_str(&str);
+        errno_t rc = clipboard_get_str(&str);
         
         if ((rc != EOK) || (str == NULL)) {
@@ -667 +667 @@
         size_t cnum;
         size_t i;
-        int rc;
+        errno_t rc;
 
         if (ti->compl_ops == NULL)
@@ -782 +782 @@
  * @return              EOK on success, ENOMEM if out of memory.
  */
-int tinput_set_prompt(tinput_t *ti, const char *prompt)
+errno_t tinput_set_prompt(tinput_t *ti, const char *prompt)
 {
         if (ti->prompt != NULL)
@@ -863 +863 @@
  *
  */
-int tinput_read_i(tinput_t *ti, const char *istr, char **dstr)
+errno_t tinput_read_i(tinput_t *ti, const char *istr, char **dstr)
 {
         console_flush(ti->console);
@@ -925 +925 @@
  *
  */
-int tinput_read(tinput_t *ti, char **dstr)
+errno_t tinput_read(tinput_t *ti, char **dstr)
 {
         return tinput_read_i(ti, "", dstr);