Changeset b7fd2a0 in mainline for uspace/lib/c/include/io/input.h


Ignore:
Timestamp:
2018-01-13T03:10:29Z (7 years ago)
Author:
Jiří Zárevúcky <zarevucky.jiri@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
a53ed3a
Parents:
36f0738
Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • uspace/lib/c/include/io/input.h

    r36f0738 rb7fd2a0  
    4848
    4949typedef struct input_ev_ops {
    50         int (*active)(input_t *);
    51         int (*deactive)(input_t *);
    52         int (*key)(input_t *, kbd_event_type_t, keycode_t, keymod_t, wchar_t);
    53         int (*move)(input_t *, int, int);
    54         int (*abs_move)(input_t *, unsigned, unsigned, unsigned, unsigned);
    55         int (*button)(input_t *, int, int);
     50        errno_t (*active)(input_t *);
     51        errno_t (*deactive)(input_t *);
     52        errno_t (*key)(input_t *, kbd_event_type_t, keycode_t, keymod_t, wchar_t);
     53        errno_t (*move)(input_t *, int, int);
     54        errno_t (*abs_move)(input_t *, unsigned, unsigned, unsigned, unsigned);
     55        errno_t (*button)(input_t *, int, int);
    5656} input_ev_ops_t;
    5757
    58 extern int input_open(async_sess_t *, input_ev_ops_t *, void *, input_t **);
     58extern errno_t input_open(async_sess_t *, input_ev_ops_t *, void *, input_t **);
    5959extern void input_close(input_t *);
    60 extern int input_activate(input_t *);
     60extern errno_t input_activate(input_t *);
    6161
    6262#endif
Note: See TracChangeset for help on using the changeset viewer.