Changeset b7fd2a0 in mainline for uspace/lib/c/generic/udebug.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/c/generic/udebug.c (modified) (15 diffs)

uspace/lib/c/generic/udebug.c

@@ -39 +39 @@
 #include <async.h>
 
-int udebug_begin(async_sess_t *sess)
+errno_t udebug_begin(async_sess_t *sess)
 {
         async_exch_t *exch = async_exchange_begin(sess);
@@ -45 +45 @@
 }
 
-int udebug_end(async_sess_t *sess)
+errno_t udebug_end(async_sess_t *sess)
 {
         async_exch_t *exch = async_exchange_begin(sess);
@@ -51 +51 @@
 }
 
-int udebug_set_evmask(async_sess_t *sess, udebug_evmask_t mask)
+errno_t udebug_set_evmask(async_sess_t *sess, udebug_evmask_t mask)
 {
         async_exch_t *exch = async_exchange_begin(sess);
@@ -57 +57 @@
 }
 
-int udebug_thread_read(async_sess_t *sess, void *buffer, size_t n,
+errno_t udebug_thread_read(async_sess_t *sess, void *buffer, size_t n,
     size_t *copied, size_t *needed)
 {
@@ -63 +63 @@
         
         async_exch_t *exch = async_exchange_begin(sess);
-        int rc = async_req_3_3(exch, IPC_M_DEBUG, UDEBUG_M_THREAD_READ,
+        errno_t rc = async_req_3_3(exch, IPC_M_DEBUG, UDEBUG_M_THREAD_READ,
             (sysarg_t) buffer, n, NULL, &a_copied, &a_needed);
         
@@ -72 +72 @@
 }
 
-int udebug_name_read(async_sess_t *sess, void *buffer, size_t n,
+errno_t udebug_name_read(async_sess_t *sess, void *buffer, size_t n,
     size_t *copied, size_t *needed)
 {
@@ -78 +78 @@
         
         async_exch_t *exch = async_exchange_begin(sess);
-        int rc = async_req_3_3(exch, IPC_M_DEBUG, UDEBUG_M_NAME_READ,
+        errno_t rc = async_req_3_3(exch, IPC_M_DEBUG, UDEBUG_M_NAME_READ,
             (sysarg_t) buffer, n, NULL, &a_copied, &a_needed);
         
@@ -87 +87 @@
 }
 
-int udebug_areas_read(async_sess_t *sess, void *buffer, size_t n,
+errno_t udebug_areas_read(async_sess_t *sess, void *buffer, size_t n,
     size_t *copied, size_t *needed)
 {
@@ -93 +93 @@
         
         async_exch_t *exch = async_exchange_begin(sess);
-        int rc = async_req_3_3(exch, IPC_M_DEBUG, UDEBUG_M_AREAS_READ,
+        errno_t rc = async_req_3_3(exch, IPC_M_DEBUG, UDEBUG_M_AREAS_READ,
             (sysarg_t) buffer, n, NULL, &a_copied, &a_needed);
         
@@ -102 +102 @@
 }
 
-int udebug_mem_read(async_sess_t *sess, void *buffer, uintptr_t addr, size_t n)
+errno_t udebug_mem_read(async_sess_t *sess, void *buffer, uintptr_t addr, size_t n)
 {
         async_exch_t *exch = async_exchange_begin(sess);
@@ -109 +109 @@
 }
 
-int udebug_args_read(async_sess_t *sess, thash_t tid, sysarg_t *buffer)
+errno_t udebug_args_read(async_sess_t *sess, thash_t tid, sysarg_t *buffer)
 {
         async_exch_t *exch = async_exchange_begin(sess);
@@ -116 +116 @@
 }
 
-int udebug_regs_read(async_sess_t *sess, thash_t tid, void *buffer)
+errno_t udebug_regs_read(async_sess_t *sess, thash_t tid, void *buffer)
 {
         async_exch_t *exch = async_exchange_begin(sess);
@@ -123 +123 @@
 }
 
-int udebug_go(async_sess_t *sess, thash_t tid, udebug_event_t *ev_type,
+errno_t udebug_go(async_sess_t *sess, thash_t tid, udebug_event_t *ev_type,
     sysarg_t *val0, sysarg_t *val1)
 {
@@ -129 +129 @@
         
         async_exch_t *exch = async_exchange_begin(sess);
-        int rc = async_req_2_3(exch, IPC_M_DEBUG, UDEBUG_M_GO,
+        errno_t rc = async_req_2_3(exch, IPC_M_DEBUG, UDEBUG_M_GO,
             tid, &a_ev_type, val0, val1);
         
@@ -136 +136 @@
 }
 
-int udebug_stop(async_sess_t *sess, thash_t tid)
+errno_t udebug_stop(async_sess_t *sess, thash_t tid)
 {
         async_exch_t *exch = async_exchange_begin(sess);