Changeset b7fd2a0 in mainline for uspace/lib/c/generic/device/clock_dev.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/c/generic/device/clock_dev.c (modified) (6 diffs)

uspace/lib/c/generic/device/clock_dev.c

@@ -46 +46 @@
  * @return         EOK on success or an error code
  */
-int
+errno_t
 clock_dev_time_get(async_sess_t *sess, struct tm *t)
 {
         aid_t req;
-        int ret;
+        errno_t ret;
 
         async_exch_t *exch = async_exchange_begin(sess);
@@ -60 +60 @@
         async_exchange_end(exch);
 
-        int rc;
+        errno_t rc;
         if (ret != EOK) {
                 async_forget(req);
@@ -67 +67 @@
 
         async_wait_for(req, &rc);
-        return (int)rc;
+        return (errno_t)rc;
 }
 
@@ -77 +77 @@
  * @return       EOK on success or an error code
  */
-int
+errno_t
 clock_dev_time_set(async_sess_t *sess, struct tm *t)
 {
         aid_t req;
-        int ret;
+        errno_t ret;
 
         async_exch_t *exch = async_exchange_begin(sess);
@@ -91 +91 @@
         async_exchange_end(exch);
 
-        int rc;
+        errno_t rc;
         if (ret != EOK) {
                 async_forget(req);
@@ -98 +98 @@
 
         async_wait_for(req, &rc);
-        return (int)rc;
+        return (errno_t)rc;
 }