Changeset b7fd2a0 in mainline for uspace/drv/char/sun4v-con/sun4v-con.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/drv/char/sun4v-con/sun4v-con.c (modified) (6 diffs)

uspace/drv/char/sun4v-con/sun4v-con.c

@@ -46 +46 @@
 #define POLL_INTERVAL  10000
 
-static int sun4v_con_read(chardev_srv_t *, void *, size_t, size_t *);
-static int sun4v_con_write(chardev_srv_t *, const void *, size_t, size_t *);
+static errno_t sun4v_con_read(chardev_srv_t *, void *, size_t, size_t *);
+static errno_t sun4v_con_write(chardev_srv_t *, const void *, size_t, size_t *);
 
 static chardev_ops_t sun4v_con_chardev_ops = {
@@ -69 +69 @@
 
 /** Add sun4v console device. */
-int sun4v_con_add(sun4v_con_t *con, sun4v_con_res_t *res)
+errno_t sun4v_con_add(sun4v_con_t *con, sun4v_con_res_t *res)
 {
         ddf_fun_t *fun = NULL;
-        int rc;
+        errno_t rc;
 
         con->res = *res;
@@ -129 +129 @@
 
 /** Remove sun4v console device */
-int sun4v_con_remove(sun4v_con_t *con)
+errno_t sun4v_con_remove(sun4v_con_t *con)
 {
         return ENOTSUP;
@@ -135 +135 @@
 
 /** Msim console device gone */
-int sun4v_con_gone(sun4v_con_t *con)
+errno_t sun4v_con_gone(sun4v_con_t *con)
 {
         return ENOTSUP;
@@ -141 +141 @@
 
 /** Read from Sun4v console device */
-static int sun4v_con_read(chardev_srv_t *srv, void *buf, size_t size,
+static errno_t sun4v_con_read(chardev_srv_t *srv, void *buf, size_t size,
     size_t *nread)
 {
@@ -165 +165 @@
 
 /** Write to Sun4v console device */
-static int sun4v_con_write(chardev_srv_t *srv, const void *data, size_t size,
+static errno_t sun4v_con_write(chardev_srv_t *srv, const void *data, size_t size,
     size_t *nwr)
 {