Changeset b7fd2a0 in mainline for uspace/drv/char/i8042/i8042.c

Timestamp:

2018-01-13T03:10:29Z (9 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/fix-logger-deadlock, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/drv/char/i8042/i8042.c (modified) (7 diffs)

uspace/drv/char/i8042/i8042.c

@@ -68 +68 @@
 
 static void i8042_char_conn(ipc_callid_t, ipc_call_t *, void *);
-static int i8042_read(chardev_srv_t *, void *, size_t, size_t *);
-static int i8042_write(chardev_srv_t *, const void *, size_t, size_t *);
+static errno_t i8042_read(chardev_srv_t *, void *, size_t, size_t *);
+static errno_t i8042_write(chardev_srv_t *, const void *, size_t, size_t *);
 
 static chardev_ops_t i8042_chardev_ops = {
@@ -129 +129 @@
 {
         i8042_t *controller = ddf_dev_data_get(dev);
-        int rc;
+        errno_t rc;
         
         const uint8_t status = IPC_GET_ARG1(*call);
@@ -158 +158 @@
  *
  */
-int i8042_init(i8042_t *dev, addr_range_t *regs, int irq_kbd,
+errno_t i8042_init(i8042_t *dev, addr_range_t *regs, int irq_kbd,
     int irq_mouse, ddf_dev_t *ddf_dev)
 {
@@ -170 +170 @@
         i8042_regs_t *ar;
         
-        int rc;
+        errno_t rc;
         bool kbd_bound = false;
         bool aux_bound = false;
@@ -350 +350 @@
  *
  */
-static int i8042_write(chardev_srv_t *srv, const void *data, size_t size,
+static errno_t i8042_write(chardev_srv_t *srv, const void *data, size_t size,
     size_t *nwr)
 {
@@ -385 +385 @@
  *
  */
-static int i8042_read(chardev_srv_t *srv, void *dest, size_t size,
+static errno_t i8042_read(chardev_srv_t *srv, void *dest, size_t size,
     size_t *nread)
 {
@@ -391 +391 @@
         size_t p;
         uint8_t *destp = (uint8_t *)dest;
-        int rc;
+        errno_t rc;
         
         fibril_mutex_lock(&port->buf_lock);