Changeset b7fd2a0 in mainline for uspace/drv/bus/isa/i8237.c

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/drv/bus/isa/i8237.c (modified) (3 diffs)

uspace/drv/bus/isa/i8237.c

@@ -279 +279 @@
  *
  */
-static inline int dma_controller_init(dma_controller_t *controller)
+static inline errno_t dma_controller_init(dma_controller_t *controller)
 {
         assert(controller);
-        int ret = pio_enable(DMA_CONTROLLER_PAGE_BASE, sizeof(dma_page_regs_t),
+        errno_t ret = pio_enable(DMA_CONTROLLER_PAGE_BASE, sizeof(dma_page_regs_t),
             (void **) &controller->page_table);
         if (ret != EOK)
@@ -339 +339 @@
  * @return Error code.
  */
-int dma_channel_setup(unsigned int channel, uint32_t pa, uint32_t size,
+errno_t dma_channel_setup(unsigned int channel, uint32_t pa, uint32_t size,
     uint8_t mode)
 {
@@ -454 +454 @@
  * @return Error code.
  */
-int dma_channel_remain(unsigned channel, size_t *size)
+errno_t dma_channel_remain(unsigned channel, size_t *size)
 {
         assert(size);