Changeset b7fd2a0 in mainline for uspace/app/wavplay/dplay.c

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/app/wavplay/dplay.c (modified) (4 diffs)

uspace/app/wavplay/dplay.c

@@ -148 +148 @@
         const size_t fragment_size = pb->buffer.size / DEFAULT_FRAGMENTS;
         printf("Registering event callback\n");
-        int ret = audio_pcm_register_event_callback(pb->device,
+        errno_t ret = audio_pcm_register_event_callback(pb->device,
             device_event_callback, pb);
         if (ret != EOK) {
@@ -282 +282 @@
 
                 if (!started) {
-                        int ret = audio_pcm_start_playback(pb->device,
+                        errno_t ret = audio_pcm_start_playback(pb->device,
                             pb->f.channels, pb->f.sampling_rate,
                             pb->f.sample_format);
@@ -309 +309 @@
                         async_usleep(real_delay);
                 /* update buffer position */
-                const int ret = audio_pcm_get_buffer_pos(pb->device, &pos);
+                const errno_t ret = audio_pcm_get_buffer_pos(pb->device, &pos);
                 if (ret != EOK) {
                         printf("Failed to update position indicator %s\n",
@@ -333 +333 @@
 int dplay(const char *device, const char *file)
 {
-        int ret = EOK;
+        errno_t ret = EOK;
         audio_pcm_sess_t *session = NULL;
         if (str_cmp(device, "default") == 0) {