Changeset b7fd2a0 in mainline for uspace/app/dnscfg/dnscfg.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/app/dnscfg/dnscfg.c (modified) (4 diffs)

uspace/app/dnscfg/dnscfg.c

@@ -55 +55 @@
 }
 
-static int dnscfg_set_ns(int argc, char *argv[])
+static errno_t dnscfg_set_ns(int argc, char *argv[])
 {
         if (argc < 1) {
@@ -72 +72 @@
         
         inet_addr_t addr;
-        int rc = inet_addr_parse(srv_addr, &addr, NULL);
+        errno_t rc = inet_addr_parse(srv_addr, &addr, NULL);
         
         if (rc != EOK) {
@@ -89 +89 @@
 }
 
-static int dnscfg_unset_ns(void)
+static errno_t dnscfg_unset_ns(void)
 {
         inet_addr_t addr;
         inet_addr_any(&addr);
         
-        int rc = dnsr_set_srvaddr(&addr);
+        errno_t rc = dnsr_set_srvaddr(&addr);
         if (rc != EOK) {
                 printf("%s: Failed unsetting server address (%s)\n",
@@ -104 +104 @@
 }
 
-static int dnscfg_print(void)
+static errno_t dnscfg_print(void)
 {
         inet_addr_t addr;
-        int rc = dnsr_get_srvaddr(&addr);
+        errno_t rc = dnsr_get_srvaddr(&addr);
         if (rc != EOK) {
                 printf("%s: Failed getting DNS server address.\n", NAME);