Changeset b0f00a9 in mainline for uspace/lib/c/generic/task.c

Timestamp:

2011-11-06T22:21:05Z (15 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/fix-logger-deadlock, topic/msim-upgrade, topic/simplify-dev-export

Children:

898e847

Parents:

2bdf8313 (diff), 7b5f4c9 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge mainline changes.

File:

• uspace/lib/c/generic/task.c (modified) (12 diffs)

uspace/lib/c/generic/task.c

@@ -35 +35 @@
 
 #include <task.h>
-#include <libc.h>
-#include <stdlib.h>
-#include <errno.h>
 #include <loader/loader.h>
 #include <stdarg.h>
@@ -43 +40 @@
 #include <ipc/ns.h>
 #include <macros.h>
+#include <assert.h>
 #include <async.h>
+#include <errno.h>
+#include <malloc.h>
+#include <libc.h>
+#include "private/ns.h"
+#include <vfs/vfs.h>
 
 task_id_t task_get_id(void)
@@ -68 +71 @@
 int task_set_name(const char *name)
 {
+        assert(name);
+        
         return __SYSCALL2(SYS_TASK_SET_NAME, (sysarg_t) name, str_size(name));
 }
@@ -88 +93 @@
  * loader API. Arguments are passed as a null-terminated array of strings.
  *
- * @param id    If not NULL, the ID of the task is stored here on success.
- * @param path  Pathname of the binary to execute.
- * @param argv  Command-line arguments.
- *
- * @return      Zero on success or negative error code.
+ * @param id   If not NULL, the ID of the task is stored here on success.
+ * @param path Pathname of the binary to execute.
+ * @param argv Command-line arguments.
+ *
+ * @return Zero on success or negative error code.
+ *
  */
 int task_spawnv(task_id_t *id, const char *path, const char *const args[])
 {
-        loader_t *ldr;
-        task_id_t task_id;
-        int rc;
-
+        /* Send default files */
+        int *files[4];
+        int fd_stdin;
+        int fd_stdout;
+        int fd_stderr;
+        
+        if ((stdin != NULL) && (fhandle(stdin, &fd_stdin) == EOK))
+                files[0] = &fd_stdin;
+        else
+                files[0] = NULL;
+        
+        if ((stdout != NULL) && (fhandle(stdout, &fd_stdout) == EOK))
+                files[1] = &fd_stdout;
+        else
+                files[1] = NULL;
+        
+        if ((stderr != NULL) && (fhandle(stderr, &fd_stderr) == EOK))
+                files[2] = &fd_stderr;
+        else
+                files[2] = NULL;
+        
+        files[3] = NULL;
+        
+        return task_spawnvf(id, path, args, files);
+}
+
+/** Create a new task by running an executable from the filesystem.
+ *
+ * This is really just a convenience wrapper over the more complicated
+ * loader API. Arguments are passed as a null-terminated array of strings.
+ * Files are passed as null-terminated array of pointers to fdi_node_t.
+ *
+ * @param id    If not NULL, the ID of the task is stored here on success.
+ * @param path  Pathname of the binary to execute.
+ * @param argv  Command-line arguments.
+ * @param files Standard files to use.
+ *
+ * @return Zero on success or negative error code.
+ *
+ */
+int task_spawnvf(task_id_t *id, const char *path, const char *const args[],
+    int *const files[])
+{
         /* Connect to a program loader. */
-        ldr = loader_connect();
+        loader_t *ldr = loader_connect();
         if (ldr == NULL)
                 return EREFUSED;
         
         /* Get task ID. */
-        rc = loader_get_task_id(ldr, &task_id);
+        task_id_t task_id;
+        int rc = loader_get_task_id(ldr, &task_id);
         if (rc != EOK)
                 goto error;
@@ -125 +171 @@
                 goto error;
         
-        /* Send default files */
-        fdi_node_t *files[4];
-        fdi_node_t stdin_node;
-        fdi_node_t stdout_node;
-        fdi_node_t stderr_node;
-        
-        if ((stdin != NULL) && (fnode(stdin, &stdin_node) == EOK))
-                files[0] = &stdin_node;
-        else
-                files[0] = NULL;
-        
-        if ((stdout != NULL) && (fnode(stdout, &stdout_node) == EOK))
-                files[1] = &stdout_node;
-        else
-                files[1] = NULL;
-        
-        if ((stderr != NULL) && (fnode(stderr, &stderr_node) == EOK))
-                files[2] = &stderr_node;
-        else
-                files[2] = NULL;
-        
-        files[3] = NULL;
-        
+        /* Send files */
         rc = loader_set_files(ldr, files);
         if (rc != EOK)
@@ -163 +187 @@
         
         /* Success */
-        free(ldr);
-        
         if (id != NULL)
                 *id = task_id;
@@ -173 +195 @@
         /* Error exit */
         loader_abort(ldr);
-        free(ldr);
         return rc;
 }
@@ -182 +203 @@
  * loader API. Arguments are passed as a null-terminated list of arguments.
  *
- * @param id    If not NULL, the ID of the task is stored here on success.
- * @param path  Pathname of the binary to execute.
- * @param ...   Command-line arguments.
- *
- * @return      Zero on success or negative error code.
+ * @param id   If not NULL, the ID of the task is stored here on success.
+ * @param path Pathname of the binary to execute.
+ * @param ...  Command-line arguments.
+ *
+ * @return Zero on success or negative error code.
+ *
  */
 int task_spawnl(task_id_t *task_id, const char *path, ...)
 {
+        /* Count the number of arguments. */
+        
         va_list ap;
-        int rc, cnt;
         const char *arg;
         const char **arglist;
-
-        /* Count the number of arguments. */
-        cnt = 0;
+        int cnt = 0;
+        
         va_start(ap, path);
         do {
@@ -203 +225 @@
         } while (arg != NULL);
         va_end(ap);
-
+        
         /* Allocate argument list. */
         arglist = malloc(cnt * sizeof(const char *));
         if (arglist == NULL)
                 return ENOMEM;
-
+        
         /* Fill in arguments. */
         cnt = 0;
@@ -217 +239 @@
         } while (arg != NULL);
         va_end(ap);
-
+        
         /* Spawn task. */
-        rc = task_spawnv(task_id, path, arglist);
-
+        int rc = task_spawnv(task_id, path, arglist);
+        
         /* Free argument list. */
         free(arglist);
@@ -228 +250 @@
 int task_wait(task_id_t id, task_exit_t *texit, int *retval)
 {
+        assert(texit);
+        assert(retval);
+        
+        async_exch_t *exch = async_exchange_begin(session_ns);
         sysarg_t te, rv;
-        int rc;
-
-        rc = (int) async_req_2_2(PHONE_NS, NS_TASK_WAIT, LOWER32(id),
+        int rc = (int) async_req_2_2(exch, NS_TASK_WAIT, LOWER32(id),
             UPPER32(id), &te, &rv);
+        async_exchange_end(exch);
+        
         *texit = te;
         *retval = rv;
-
+        
         return rc;
 }
@@ -241 +267 @@
 int task_retval(int val)
 {
-        return (int) async_req_1_0(PHONE_NS, NS_RETVAL, val);
+        async_exch_t *exch = async_exchange_begin(session_ns);
+        int rc = (int) async_req_1_0(exch, NS_RETVAL, val);
+        async_exchange_end(exch);
+        
+        return rc;
 }