Changeset a501aaba in mainline for uspace/drv/bus/usb/xhci/hw_struct/trb.h

Timestamp:

2017-10-26T22:21:30Z (8 years ago)

Author:

Ondřej Hlavatý <aearsis@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

5bc8250

Parents:

928afc8d

Message:

xhci trb_ring: fix ring wrapping

The Toggle Cycle of the Link TRB must be set, not the Cycle flag.

File:

• uspace/drv/bus/usb/xhci/hw_struct/trb.h (modified) (2 diffs)

uspace/drv/bus/usb/xhci/hw_struct/trb.h

@@ -105 +105 @@
 #define TRB_COMPLETION_CODE(trb)        XHCI_DWORD_EXTRACT((trb).status, 31, 24)
 
+#define TRB_LINK_SET_TC(trb, val) \
+        xhci_dword_set_bits(&(trb).control, val, 1, 1)
+#define TRB_SET_CYCLE(trb, val) \
+        xhci_dword_set_bits(&(trb).control, val, 0, 0)
+
 #define TRB_CTRL_SET_SETUP_WLENGTH(trb, val) \
         xhci_qword_set_bits(&(trb).parameter, val, 63, 48)
@@ -153 +158 @@
             || type == XHCI_TRB_TYPE_STATUS_STAGE
             || type == XHCI_TRB_TYPE_ISOCH);
-}
-
-static inline void xhci_trb_set_cycle(xhci_trb_t *trb, bool cycle)
-{
-        xhci_dword_set_bits(&trb->control, cycle, 0, 0);
 }