Changeset a46e56b in mainline for uspace/srv/ns/service.c

Timestamp:

2018-03-22T06:49:35Z (7 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

77f0a1d

Parents:

3e242d2

git-author:

Jakub Jermar <jakub@…> (2018-03-21 23:29:06)

git-committer:

Jakub Jermar <jakub@…> (2018-03-22 06:49:35)

Message:

Prefer handle over ID in naming handle variables

File:

• uspace/srv/ns/service.c (modified) (6 diffs)

uspace/srv/ns/service.c

@@ -87 +87 @@
 typedef struct {
         link_t link;
-        service_t service;    /**< Service ID */
-        iface_t iface;        /**< Interface ID */
-        cap_call_handle_t callid;  /**< Call ID waiting for the connection */
-        sysarg_t arg3;        /**< Third argument */
+        service_t service;         /**< Service ID */
+        iface_t iface;             /**< Interface ID */
+        cap_call_handle_t chandle; /**< Call handle waiting for the connection */
+        sysarg_t arg3;             /**< Third argument */
 } pending_conn_t;
 
@@ -119 +119 @@
                 hashed_service_t *hashed_service = hash_table_get_inst(link, hashed_service_t, link);
                 async_exch_t *exch = async_exchange_begin(hashed_service->sess);
-                async_forward_fast(pending->callid, exch, pending->iface,
+                async_forward_fast(pending->chandle, exch, pending->iface,
                     pending->arg3, 0, IPC_FF_NONE);
                 async_exchange_end(exch);
@@ -163 +163 @@
  * @param iface   Interface to be connected to.
  * @param call    Pointer to call structure.
- * @param callid  Call ID of the request.
+ * @param chandle  Call ID of the request.
  *
  * @return Zero on success or a value from @ref errno.h.
@@ -169 +169 @@
  */
 void connect_to_service(service_t service, iface_t iface, ipc_call_t *call,
-    cap_call_handle_t callid)
+    cap_call_handle_t chandle)
 {
         sysarg_t arg3 = IPC_GET_ARG3(*call);
@@ -189 +189 @@
                         pending->service = service;
                         pending->iface = iface;
-                        pending->callid = callid;
+                        pending->chandle = chandle;
                         pending->arg3 = arg3;
 
@@ -202 +202 @@
         hashed_service_t *hashed_service = hash_table_get_inst(link, hashed_service_t, link);
         async_exch_t *exch = async_exchange_begin(hashed_service->sess);
-        async_forward_fast(callid, exch, iface, arg3, 0, IPC_FF_NONE);
+        async_forward_fast(chandle, exch, iface, arg3, 0, IPC_FF_NONE);
         async_exchange_end(exch);
         return;
 
 out:
-        async_answer_0(callid, retval);
+        async_answer_0(chandle, retval);
 }