Changeset a35b458 in mainline for tools/ew.py


Ignore:
Timestamp:
2018-03-02T20:10:49Z (7 years ago)
Author:
Jiří Zárevúcky <zarevucky.jiri@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
f1380b7
Parents:
3061bc1
git-author:
Jiří Zárevúcky <zarevucky.jiri@…> (2018-02-28 17:38:31)
git-committer:
Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-02 20:10:49)
Message:

style: Remove trailing whitespace on _all_ lines, including empty ones, for particular file types.

Command used: tools/srepl '\s\+$' '' -- *.c *.h *.py *.sh *.s *.S *.ag

Currently, whitespace on empty lines is very inconsistent.
There are two basic choices: Either remove the whitespace, or keep empty lines
indented to the level of surrounding code. The former is AFAICT more common,
and also much easier to do automatically.

Alternatively, we could write script for automatic indentation, and use that
instead. However, if such a script exists, it's possible to use the indented
style locally, by having the editor apply relevant conversions on load/save,
without affecting remote repository. IMO, it makes more sense to adopt
the simpler rule.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • tools/ew.py

    r3061bc1 ra35b458  
    7676def pc_options(guest_width):
    7777        opts = ''
    78        
     78
    7979        # Do not enable KVM if running 64 bits HelenOS
    8080        # on 32 bits host
     
    8282        if guest_width <= host_width and not is_override('nokvm'):
    8383                opts = opts + ' -enable-kvm'
    84        
     84
    8585        # Remove the leading space
    8686        return opts[1:]
     
    132132        if is_override('nohdd'):
    133133                return ''
    134        
     134
    135135        hdisk_mk()
    136        
     136
    137137        return ' -drive file=hdisk.img,index=0,media=disk,format=raw'
    138138
     
    208208        if (not 'audio' in cfg.keys()) or cfg['audio']:
    209209                cmdline += qemu_audio_options()
    210        
     210
    211211        if cfg['image'] == 'image.iso':
    212212                cmdline += ' -boot d -cdrom image.iso'
     
    328328def fail(platform, machine):
    329329        print("Cannot start emulation for the chosen configuration. (%s/%s)" % (platform, machine))
    330        
     330
    331331
    332332def run():
Note: See TracChangeset for help on using the changeset viewer.