Changeset a33f0a6 in mainline for uspace/srv/devman/devman.c

Timestamp:

2011-08-03T17:34:57Z (15 years ago)

Author:

Oleg Romanenko <romanenko.oleg@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

1940326

Parents:

52a79081 (diff), 3fab770 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge from mainline

File:

• uspace/srv/devman/devman.c (modified) (19 diffs)

uspace/srv/devman/devman.c

@@ -270 +270 @@
         }
         
-        ssize_t read_bytes = safe_read(fd, buf, len);
+        ssize_t read_bytes = read_all(fd, buf, len);
         if (read_bytes <= 0) {
-                log_msg(LVL_ERROR, "Unable to read file '%s'.", conf_path);
+                log_msg(LVL_ERROR, "Unable to read file '%s' (%zd).", conf_path,
+                    read_bytes);
                 goto cleanup;
         }
@@ -421 +422 @@
         }
         
-        insert_fun_node(tree, fun, clone_string(""), NULL);
+        insert_fun_node(tree, fun, str_dup(""), NULL);
         match_id_t *id = create_match_id();
-        id->id = clone_string("root");
+        id->id = str_dup("root");
         id->score = 100;
         add_match_id(&fun->match_ids, id);
@@ -466 +467 @@
         fibril_mutex_lock(&drivers_list->drivers_mutex);
         
-        link_t *link = drivers_list->drivers.next;
-        while (link != &drivers_list->drivers) {
+        list_foreach(drivers_list->drivers, link) {
                 drv = list_get_instance(link, driver_t, drivers);
                 score = get_match_score(drv, node);
@@ -474 +474 @@
                         best_drv = drv;
                 }
-                link = link->next;
         }
         
@@ -536 +535 @@
         driver_t *res = NULL;
         driver_t *drv = NULL;
-        link_t *link;
         
         fibril_mutex_lock(&drv_list->drivers_mutex);
         
-        link = drv_list->drivers.next;
-        while (link != &drv_list->drivers) {
+        list_foreach(drv_list->drivers, link) {
                 drv = list_get_instance(link, driver_t, drivers);
                 if (str_cmp(drv->name, drv_name) == 0) {
@@ -547 +544 @@
                         break;
                 }
-
-                link = link->next;
         }
         
@@ -564 +559 @@
         dev_node_t *dev;
         link_t *link;
-        int phone;
 
         log_msg(LVL_DEBUG, "pass_devices_to_driver(driver=\"%s\")",
@@ -570 +564 @@
 
         fibril_mutex_lock(&driver->driver_mutex);
-
-        phone = async_connect_me_to(driver->phone, DRIVER_DEVMAN, 0, 0);
-
-        if (phone < 0) {
+        
+        async_exch_t *exch = async_exchange_begin(driver->sess);
+        async_sess_t *sess = async_connect_me_to(EXCHANGE_SERIALIZE, exch,
+            DRIVER_DEVMAN, 0, 0);
+        async_exchange_end(exch);
+
+        if (!sess) {
                 fibril_mutex_unlock(&driver->driver_mutex);
                 return;
@@ -582 +579 @@
          * that has not been passed to the driver.
          */
-        link = driver->devices.next;
-        while (link != &driver->devices) {
+        link = driver->devices.head.next;
+        while (link != &driver->devices.head) {
                 dev = list_get_instance(link, dev_node_t, driver_devices);
                 if (dev->passed_to_driver) {
@@ -602 +599 @@
                 fibril_mutex_unlock(&driver->driver_mutex);
 
-                add_device(phone, driver, dev, tree);
+                add_device(sess, driver, dev, tree);
 
                 /*
@@ -620 +617 @@
                  * Restart the cycle to go through all devices again.
                  */
-                link = driver->devices.next;
-        }
-
-        async_hangup(phone);
+                link = driver->devices.head.next;
+        }
+
+        async_hangup(sess);
 
         /*
@@ -673 +670 @@
         list_initialize(&drv->devices);
         fibril_mutex_initialize(&drv->driver_mutex);
-        drv->phone = -1;
+        drv->sess = NULL;
 }
 
@@ -737 +734 @@
  * @param node          The device's node in the device tree.
  */
-void add_device(int phone, driver_t *drv, dev_node_t *dev, dev_tree_t *tree)
+void add_device(async_sess_t *sess, driver_t *drv, dev_node_t *dev,
+    dev_tree_t *tree)
 {
         /*
@@ -746 +744 @@
             drv->name, dev->pfun->name);
         
-        sysarg_t rc;
-        ipc_call_t answer;
-        
         /* Send the device to the driver. */
         devman_handle_t parent_handle;
@@ -756 +751 @@
                 parent_handle = 0;
         }
-
-        aid_t req = async_send_2(phone, DRIVER_ADD_DEVICE, dev->handle,
+        
+        async_exch_t *exch = async_exchange_begin(sess);
+        
+        ipc_call_t answer;
+        aid_t req = async_send_2(exch, DRIVER_ADD_DEVICE, dev->handle,
             parent_handle, &answer);
         
-        /* Send the device's name to the driver. */
-        rc = async_data_write_start(phone, dev->pfun->name,
+        /* Send the device name to the driver. */
+        sysarg_t rc = async_data_write_start(exch, dev->pfun->name,
             str_size(dev->pfun->name) + 1);
+        
+        async_exchange_end(exch);
+        
         if (rc != EOK) {
                 /* TODO handle error */
@@ -823 +824 @@
         if (is_running) {
                 /* Notify the driver about the new device. */
-                int phone = async_connect_me_to(drv->phone, DRIVER_DEVMAN, 0, 0);
-                if (phone >= 0) {
-                        add_device(phone, drv, dev, tree);
-                        async_hangup(phone);
+                async_exch_t *exch = async_exchange_begin(drv->sess);
+                async_sess_t *sess = async_connect_me_to(EXCHANGE_SERIALIZE, exch,
+                    DRIVER_DEVMAN, 0, 0);
+                async_exchange_end(exch);
+                
+                if (sess) {
+                        add_device(sess, drv, dev, tree);
+                        async_hangup(sess);
                 }
         }
@@ -1177 +1182 @@
 
         fun_node_t *fun;
-        link_t *link;
-
-        for (link = dev->functions.next;
-            link != &dev->functions;
-            link = link->next) {
+
+        list_foreach(dev->functions, link) {
                 fun = list_get_instance(link, fun_node_t, dev_functions);
 
@@ -1375 +1377 @@
 {
         dev_class_t *cl;
-        link_t *link = class_list->classes.next;
-        
-        while (link != &class_list->classes) {
+        
+        list_foreach(class_list->classes, link) {
                 cl = list_get_instance(link, dev_class_t, link);
                 if (str_cmp(cl->name, class_name) == 0) {
                         return cl;
                 }
-                link = link->next;
         }
         
@@ -1398 +1398 @@
         assert(dev_name != NULL);
 
-        link_t *link;
-        for (link = dev_class->devices.next;
-            link != &dev_class->devices;
-            link = link->next) {
+        list_foreach(dev_class->devices, link) {
                 dev_class_info_t *dev = list_get_instance(link,
                     dev_class_info_t, link);