Changeset a1732929 in mainline for uspace/drv/bus/usb/uhci/uhci_batch.c

Timestamp:

2018-01-15T17:04:34Z (7 years ago)

Author:

Ondřej Hlavatý <aearsis@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

9ff99e8

Parents:

c1a966e

git-author:

Ondřej Hlavatý <aearsis@…> (2018-01-15 17:04:32)

git-committer:

Ondřej Hlavatý <aearsis@…> (2018-01-15 17:04:34)

Message:

usb: unified logging

Use logger instead of printf. Logger adds newlines automatically.

File:

• uspace/drv/bus/usb/uhci/uhci_batch.c (modified) (7 diffs)

uspace/drv/bus/usb/uhci/uhci_batch.c

@@ -75 +75 @@
             calloc(1, sizeof(uhci_transfer_batch_t));
         if (!uhci_batch) {
-                usb_log_error("Failed to allocate UHCI batch.\n");
+                usb_log_error("Failed to allocate UHCI batch.");
                 return NULL;
         }
@@ -112 +112 @@
         uhci_batch->device_buffer = malloc32(total_size);
         if (!uhci_batch->device_buffer) {
-                usb_log_error("Failed to allocate UHCI buffer.\n");
+                usb_log_error("Failed to allocate UHCI buffer.");
                 return ENOMEM;
         }
@@ -135 +135 @@
         }
         usb_log_debug2("Batch %p " USB_TRANSFER_BATCH_FMT
-            " memory structures ready.\n", usb_batch,
+            " memory structures ready.", usb_batch,
             USB_TRANSFER_BATCH_ARGS(*usb_batch));
 
@@ -159 +159 @@
 
         usb_log_debug2("Batch %p " USB_TRANSFER_BATCH_FMT
-            " checking %zu transfer(s) for completion.\n",
+            " checking %zu transfer(s) for completion.",
             uhci_batch, USB_TRANSFER_BATCH_ARGS(*batch),
             uhci_batch->td_count);
@@ -174 +174 @@
 
                         usb_log_debug("Batch %p found error TD(%zu->%p):%"
-                            PRIx32 ".\n", uhci_batch, i,
+                            PRIx32 ".", uhci_batch, i,
                             &uhci_batch->tds[i], uhci_batch->tds[i].status);
                         td_print_status(&uhci_batch->tds[i]);
@@ -260 +260 @@
         uhci_batch->base.ep->toggle = toggle;
         usb_log_debug2(
-            "Batch %p %s %s " USB_TRANSFER_BATCH_FMT " initialized.\n", \
+            "Batch %p %s %s " USB_TRANSFER_BATCH_FMT " initialized.", \
             uhci_batch,
             usb_str_transfer_type(uhci_batch->base.ep->transfer_type),
@@ -333 +333 @@
         td_set_ioc(&uhci_batch->tds[td]);
 
-        usb_log_debug2("Control last TD status: %x.\n",
+        usb_log_debug2("Control last TD status: %x.",
             uhci_batch->tds[td].status);
 }