Changeset 9e2132a in mainline for uspace/drv/bus/usb/usbmid/explore.c

Timestamp:

2012-12-30T20:14:13Z (12 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

17bbb28

Parents:

6df4adc4

Message:

usbmid: Don't use ddf_fun_data_implant.

Remove unused pointer to interface descriptor.

File:

• uspace/drv/bus/usb/usbmid/explore.c (modified) (2 diffs)

uspace/drv/bus/usb/usbmid/explore.c

@@ -111 +111 @@
                 }
 
-                usbmid_interface_t *iface = malloc(sizeof(usbmid_interface_t));
-                if (iface == NULL) {
-                        //TODO: Do something about that failure.
-                        break;
-                }
-
-                link_initialize(&iface->link);
-                iface->fun = NULL;
-                iface->interface_no = interface->interface_number;
-                iface->interface = interface;
-
-                list_append(&iface->link, list);
 
                 usb_log_info("Creating child for interface %d (%s).\n",
@@ -128 +116 @@
                     usb_str_class(interface->interface_class));
 
-                const int rc = usbmid_spawn_interface_child(usb_dev, iface,
+                usbmid_interface_t *iface = NULL;
+                const int rc = usbmid_spawn_interface_child(usb_dev, &iface,
                     &usb_dev->descriptors.device, interface);
                 if (rc != EOK) {
+                        //TODO: Do something about that failure.
                         usb_log_error("Failed to create interface child for "
                             "%d (%s): %s.\n", interface->interface_number,
                             usb_str_class(interface->interface_class),
                             str_error(rc));
+                } else {
+                        list_append(&iface->link, list);
                 }
         }