Changeset 975d528 in mainline for uspace/srv/net/tcp/tqueue.c

Timestamp:

2017-09-10T17:48:58Z (8 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

e1b4ae0

Parents:

12dcd5f

Message:

Add unit tests for TCP tqueue. Fix tqueue possibly being finalized without freeing pending segments.

File:

• uspace/srv/net/tcp/tqueue.c (modified) (8 diffs)

uspace/srv/net/tcp/tqueue.c

@@ -47 +47 @@
 #include "inet.h"
 #include "ncsim.h"
-#include "pdu.h"
 #include "rqueue.h"
 #include "segment.h"
@@ -56 +55 @@
 #define RETRANSMIT_TIMEOUT      (2*1000*1000)
 
-static void retransmit_timeout_func(void *arg);
-static void tcp_tqueue_timer_set(tcp_conn_t *conn);
-static void tcp_tqueue_timer_clear(tcp_conn_t *conn);
-
-int tcp_tqueue_init(tcp_tqueue_t *tqueue, tcp_conn_t *conn)
+static void retransmit_timeout_func(void *);
+static void tcp_tqueue_timer_set(tcp_conn_t *);
+static void tcp_tqueue_timer_clear(tcp_conn_t *);
+static void tcp_tqueue_seg(tcp_conn_t *, tcp_segment_t *);
+static void tcp_conn_transmit_segment(tcp_conn_t *, tcp_segment_t *);
+static void tcp_prepare_transmit_segment(tcp_conn_t *, tcp_segment_t *);
+static void tcp_tqueue_send_immed(tcp_conn_t *, tcp_segment_t *);
+
+int tcp_tqueue_init(tcp_tqueue_t *tqueue, tcp_conn_t *conn,
+    tcp_tqueue_cb_t *cb)
 {
         tqueue->conn = conn;
         tqueue->timer = fibril_timer_create(&conn->lock);
+        tqueue->cb = cb;
         if (tqueue->timer == NULL)
                 return ENOMEM;
@@ -79 +84 @@
 void tcp_tqueue_fini(tcp_tqueue_t *tqueue)
 {
+        link_t *link;
+        tcp_tqueue_entry_t *tqe;
+
         if (tqueue->timer != NULL) {
                 fibril_timer_destroy(tqueue->timer);
                 tqueue->timer = NULL;
         }
+
+        while (!list_empty(&tqueue->list)) {
+                link = list_first(&tqueue->list);
+                tqe = list_get_instance(link, tcp_tqueue_entry_t, link);
+                list_remove(link);
+
+                tcp_segment_delete(tqe->seg);
+                free(tqe);
+        }
 }
 
@@ -96 +113 @@
 }
 
-void tcp_tqueue_seg(tcp_conn_t *conn, tcp_segment_t *seg)
+static void tcp_tqueue_seg(tcp_conn_t *conn, tcp_segment_t *seg)
 {
         tcp_segment_t *rt_seg;
@@ -136 +153 @@
 }
 
-void tcp_prepare_transmit_segment(tcp_conn_t *conn, tcp_segment_t *seg)
+static void tcp_prepare_transmit_segment(tcp_conn_t *conn, tcp_segment_t *seg)
 {
         /*
@@ -268 +285 @@
 }
 
-void tcp_conn_transmit_segment(tcp_conn_t *conn, tcp_segment_t *seg)
+static void tcp_conn_transmit_segment(tcp_conn_t *conn, tcp_segment_t *seg)
 {
         log_msg(LOG_DEFAULT, LVL_DEBUG, "%s: tcp_conn_transmit_segment(%p, %p)",
@@ -280 +297 @@
                 seg->ack = 0;
 
-        tcp_transmit_segment(&conn->ident, seg);
-}
-
-void tcp_transmit_segment(inet_ep2_t *epp, tcp_segment_t *seg)
+        tcp_tqueue_send_immed(conn, seg);
+}
+
+void tcp_tqueue_send_immed(tcp_conn_t *conn, tcp_segment_t *seg)
 {
         log_msg(LOG_DEFAULT, LVL_DEBUG,
-            "tcp_transmit_segment(l:(%u),f:(%u), %p)",
-            epp->local.port, epp->remote.port, seg);
+            "tcp_tqueue_send_immed(l:(%u),f:(%u), %p)",
+            conn->ident.local.port, conn->ident.remote.port, seg);
 
         log_msg(LOG_DEFAULT, LVL_DEBUG, "SEG.SEQ=%" PRIu32 ", SEG.WND=%" PRIu32,
@@ -293 +310 @@
 
         tcp_segment_dump(seg);
-/*
-        tcp_pdu_prepare(conn, seg, &data, &len);
-        tcp_pdu_transmit(data, len);
-*/
-//      tcp_rqueue_bounce_seg(sp, seg);
-//      tcp_ncsim_bounce_seg(sp, seg);
-
-        tcp_pdu_t *pdu;
-
-        if (tcp_pdu_encode(epp, seg, &pdu) != EOK) {
-                log_msg(LOG_DEFAULT, LVL_WARN, "Not enough memory. Segment dropped.");
-                return;
-        }
-
-        tcp_transmit_pdu(pdu);
-        tcp_pdu_delete(pdu);
+
+        conn->retransmit.cb->transmit_seg(&conn->ident, seg);
 }