Changeset 91b60499 in mainline for uspace/drv/block/ddisk/ddisk.c

Timestamp:

2017-09-30T06:29:42Z (7 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

300f4c4

Parents:

d076f16 (diff), 6636fb19 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge support for capabilities from lp:~jakub/helenos/caps

This commit introduces capabilities as task-local names for references to kernel
objects. Kernel objects are reference-counted wrappers for a select group of
objects allocated in and by the kernel that can be made accessible to userspace
in a controlled way via integer handles.

So far, a kernel object encapsulates either an irq_t or a phone_t.

Support for the former lead to the removal of kernel-assigned devnos and
unsecure deregistration of IRQs in which a random task was able to unregister
some other task's IRQ.

File:

• uspace/drv/block/ddisk/ddisk.c (modified) (4 diffs)

uspace/drv/block/ddisk/ddisk.c

@@ -112 +112 @@
         ddisk_regs_t *ddisk_regs;
 
+        int irq_cap;
+
         bd_srvs_t bds;
 } ddisk_t;
@@ -447 +449 @@
         ddisk->bds.sarg = ddisk;
 
+        ddisk->irq_cap = -1;
+
         /*
          * Enable access to ddisk's PIO registers.
@@ -499 +503 @@
         ddisk_irq_commands[0].addr = (void *) &res_phys->status;
         ddisk_irq_commands[3].addr = (void *) &res_phys->command;
-        rc = register_interrupt_handler(dev, ddisk->ddisk_res.irq,
+        ddisk->irq_cap = register_interrupt_handler(dev, ddisk->ddisk_res.irq,
             ddisk_irq_handler, &ddisk_irq_code);
-        if (rc != EOK) {
+        if (ddisk->irq_cap < 0) {
+                rc = ddisk->irq_cap;
                 ddf_msg(LVL_ERROR, "Failed to register interrupt handler.");
                 goto error;
@@ -541 +546 @@
         }
 
-        unregister_interrupt_handler(ddisk->dev, ddisk->ddisk_res.irq);
+        unregister_interrupt_handler(ddisk->dev, ddisk->irq_cap);
         
         rc = pio_disable(ddisk->ddisk_regs, sizeof(ddisk_regs_t));