Changeset 9043309c in mainline for kernel/arch/ia64/src/mm/tlb.c

Timestamp:

2012-11-18T00:10:02Z (12 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

7ad17de

Parents:

6f5e213

Message:

Avoid accidental restoring of rr7 to a non-kernel RID.

File:

• kernel/arch/ia64/src/mm/tlb.c (modified) (4 diffs)

kernel/arch/ia64/src/mm/tlb.c

@@ -113 +113 @@
         va = page;
         
-        rr.word = rr_read(VA2VRN(va));
-        if ((restore_rr = (rr.map.rid != ASID2RID(asid, VA2VRN(va))))) {
+        rr.word = rr_read(VA2VRN(page));
+        if ((restore_rr = (rr.map.rid != ASID2RID(asid, VA2VRN(page))))) {
                 /*
                  * The selected region register does not contain required RID.
@@ -122 +122 @@
                 
                 rr0 = rr;
-                rr0.map.rid = ASID2RID(asid, VA2VRN(va));
-                rr_write(VA2VRN(va), rr0.word);
+                rr0.map.rid = ASID2RID(asid, VA2VRN(page));
+                rr_write(VA2VRN(page), rr0.word);
                 srlz_d();
                 srlz_i();
@@ -139 +139 @@
         case 1: /* cnt 4 - 15 */
                 ps = PAGE_WIDTH + 2;
-                va &= ~((1 << ps) - 1);
+                va &= ~((1UL << ps) - 1);
                 break;
         case 2: /* cnt 16 - 63 */
                 ps = PAGE_WIDTH + 4;
-                va &= ~((1 << ps) - 1);
+                va &= ~((1UL << ps) - 1);
                 break;
         case 3: /* cnt 64 - 255 */
                 ps = PAGE_WIDTH + 6;
-                va &= ~((1 << ps) - 1);
+                va &= ~((1UL << ps) - 1);
                 break;
         case 4: /* cnt 256 - 1023 */
                 ps = PAGE_WIDTH + 8;
-                va &= ~((1 << ps) - 1);
+                va &= ~((1UL << ps) - 1);
                 break;
         case 5: /* cnt 1024 - 4095 */
                 ps = PAGE_WIDTH + 10;
-                va &= ~((1 << ps) - 1);
+                va &= ~((1UL << ps) - 1);
                 break;
         case 6: /* cnt 4096 - 16383 */
                 ps = PAGE_WIDTH + 12;
-                va &= ~((1 << ps) - 1);
+                va &= ~((1UL << ps) - 1);
                 break;
         case 7: /* cnt 16384 - 65535 */
         case 8: /* cnt 65536 - (256K - 1) */
                 ps = PAGE_WIDTH + 14;
-                va &= ~((1 << ps) - 1);
+                va &= ~((1UL << ps) - 1);
                 break;
         default:
                 ps = PAGE_WIDTH + 18;
-                va &= ~((1 << ps) - 1);
+                va &= ~((1UL << ps) - 1);
                 break;
         }
         
-        for (; va < (page + cnt * PAGE_SIZE); va += (1 << ps))
+        for (; va < (page + cnt * PAGE_SIZE); va += (1UL << ps))
                 asm volatile (
                         "ptc.l %[va], %[ps] ;;"
@@ -183 +183 @@
         
         if (restore_rr) {
-                rr_write(VA2VRN(va), rr.word);
+                rr_write(VA2VRN(page), rr.word);
                 srlz_d();
                 srlz_i();