Changeset 8e3498b in mainline for uspace/app/bdsh/cmds/modules/cp/cp.c

Timestamp:

2017-12-04T18:44:24Z (7 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

bde5c04

Parents:

40feeac

Message:

vfs_read/write() should return error code separately from number of bytes transferred.

File:

• uspace/app/bdsh/cmds/modules/cp/cp.c (modified) (17 diffs)

uspace/app/bdsh/cmds/modules/cp/cp.c

@@ -66 +66 @@
 } dentry_type_t;
 
-static int64_t copy_file(const char *src, const char *dest,
+static int copy_file(const char *src, const char *dest,
     size_t blen, int vb);
 
@@ -175 +175 @@
 }
 
-static int64_t do_copy(const char *src, const char *dest,
+static int do_copy(const char *src, const char *dest,
     size_t blen, int vb, int recursive, int force, int interactive)
 {
-        int r = -1;
+        int rc = EOK;
         char dest_path[PATH_MAX];
         char src_path[PATH_MAX];
@@ -217 +217 @@
                                 printf("The dest directory %s does not exists",
                                     dest_path);
+                                rc = ENOENT;
                                 goto exit;
                         }
@@ -224 +225 @@
                         printf("Cannot overwrite existing directory %s\n",
                             dest_path);
+                        rc = EEXIST;
                         goto exit;
                 } else if (dest_type == TYPE_FILE) {
@@ -233 +235 @@
                          */
                         if (force && !interactive) {
-                                if (vfs_unlink_path(dest_path) != EOK) {
+                                rc = vfs_unlink_path(dest_path);
+                                if (rc != EOK) {
                                         printf("Unable to remove %s\n",
                                             dest_path);
@@ -244 +247 @@
                                 if (overwrite) {
                                         printf("Overwriting file: %s\n", dest_path);
-                                        if (vfs_unlink_path(dest_path) != EOK) {
+                                        rc = vfs_unlink_path(dest_path);
+                                        if (rc != EOK) {
                                                 printf("Unable to remove %s\n", dest_path);
                                                 goto exit;
@@ -250 +254 @@
                                 } else {
                                         printf("Not overwriting file: %s\n", dest_path);
-                                        r = 0;
+                                        rc = EOK;
                                         goto exit;
                                 }
                         } else {
                                 printf("File already exists: %s\n", dest_path);
+                                rc = EEXIST;
                                 goto exit;
                         }
@@ -260 +265 @@
 
                 /* call copy_file and exit */
-                r = (copy_file(src, dest_path, blen, vb) < 0);
+                rc = (copy_file(src, dest_path, blen, vb) < 0);
 
         } else if (src_type == TYPE_DIR) {
@@ -268 +273 @@
                         printf("Cannot copy the %s directory without the "
                             "-r option\n", src);
+                        rc = EINVAL;
                         goto exit;
                 } else if (dest_type == TYPE_FILE) {
                         printf("Cannot overwrite a file with a directory\n");
+                        rc = EEXIST;
                         goto exit;
                 }
@@ -293 +300 @@
                                 merge_paths(dest_path, PATH_MAX, src_dirname);
 
-                                if (vfs_link_path(dest_path, KIND_DIRECTORY,
-                                    NULL) != EOK) {
+                                rc = vfs_link_path(dest_path, KIND_DIRECTORY,
+                                    NULL);
+                                if (rc != EOK) {
                                         printf("Unable to create "
                                             "dest directory %s\n", dest_path);
@@ -308 +316 @@
                          * e.g. cp -r /src /data/new_dir_src
                          */
-                        if (vfs_link_path(dest_path, KIND_DIRECTORY,
-                            NULL) != EOK) {
+                        rc = vfs_link_path(dest_path, KIND_DIRECTORY, NULL);
+                        if (rc != EOK) {
                                 printf("Unable to create "
                                     "dest directory %s\n", dest_path);
@@ -321 +329 @@
                         /* Something strange is happening... */
                         printf("Unable to open src %s directory\n", src);
+                        rc = ENOENT;
                         goto exit;
                 }
@@ -348 +357 @@
                                 printf("Cannot copy a directory "
                                     "into itself\n");
+                                rc = EEXIST;
                                 goto exit;
                         }
@@ -355 +365 @@
 
                         /* Recursively call do_copy() */
-                        r = do_copy(src_dent, dest_dent, blen, vb, recursive,
+                        rc = do_copy(src_dent, dest_dent, blen, vb, recursive,
                             force, interactive);
-                        if (r)
+                        if (rc != EOK)
                                 goto exit;
 
@@ -367 +377 @@
         if (dir)
                 closedir(dir);
-        return r;
-}
-
-static int64_t copy_file(const char *src, const char *dest,
+        return rc;
+}
+
+static int copy_file(const char *src, const char *dest,
         size_t blen, int vb)
 {
-        int fd1, fd2, bytes;
+        int fd1, fd2;
+        size_t rbytes, wbytes;
+        int rc;
         off64_t total;
-        int64_t copied = 0;
         char *buff = NULL;
         aoff64_t posr = 0, posw = 0;
@@ -410 +421 @@
                 printf("Unable to allocate enough memory to read %s\n",
                     src);
-                copied = -1;
+                rc = ENOMEM;
                 goto out;
         }
 
-        while ((bytes = vfs_read(fd1, &posr, buff, blen)) > 0) {
-                if ((bytes = vfs_write(fd2, &posw, buff, bytes)) < 0)
-                        break;
-                copied += bytes;
-        }
-
-        if (bytes < 0) {
-                printf("\nError copying %s, (%d)\n", src, bytes);
-                copied = bytes;
+        while ((rc = vfs_read(fd1, &posr, buff, blen, &rbytes)) == EOK &&
+            rbytes > 0) {
+                if ((rc = vfs_write(fd2, &posw, buff, rbytes, &wbytes)) != EOK)
+                        break;
+        }
+
+        if (rc != EOK) {
+                printf("\nError copying %s, (%d)\n", src, rc);
+                return rc;
         }
 
@@ -430 +441 @@
         if (buff)
                 free(buff);
-        return copied;
+        return rc;
 }