Changeset 84a1a54 in mainline for uspace/srv/bd/sata_bd/sata_bd.c


Ignore:
Timestamp:
2018-01-04T20:47:53Z (7 years ago)
Author:
Jiří Zárevúcky <zarevucky.jiri@…>
Children:
facacc71
Parents:
cde999a
Message:

Wrap returns of errno from main() with EXIT_RC().

Returns of error code from main() prevent type checking when errno_t
and int are considered incompatible. In order to avoid the philosophical
discussion of what should and shouldn't be returned for main(), we simply
wrap the error values and leave the answer to the question for future
generations to decide.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • uspace/srv/bd/sata_bd/sata_bd.c

    rcde999a r84a1a54  
    253253        if (rc != EOK) {
    254254                printf(NAME ": Unable to register driver: %s.\n", str_error(rc));
    255                 return rc;
     255                return EXIT_RC(rc);
    256256        }
    257257       
    258258        rc = get_sata_disks();
    259259        if (rc != EOK) {
    260                 // TODO: log the error
    261                 return rc;
     260                printf(NAME ": Cannot find SATA disks: %s.\n", str_error(rc));
     261                return EXIT_RC(rc);
    262262        }
    263263
     
    265265        if (rc != EOK) {
    266266                printf("%s: Failed resolving category 'disk': %s.\n", NAME, str_error(rc));
    267                 return rc;
     267                return EXIT_RC(rc);
    268268        }
    269269
     
    274274                if (rc != EOK) {
    275275                        printf(NAME ": Unable to register device %s: %s\n", name, str_error(rc));
    276                         return rc;
     276                        return EXIT_RC(rc);
    277277                }
    278278
     
    281281                        printf("%s: Failed adding %s to category: %s.",
    282282                            NAME, disk[i].dev_name, str_error(rc));
    283                         return rc;
     283                        return EXIT_RC(rc);
    284284                }
    285285        }
Note: See TracChangeset for help on using the changeset viewer.