Changeset 84a1a54 in mainline for uspace/srv/bd/sata_bd/sata_bd.c

Timestamp:

2018-01-04T20:47:53Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Children:

facacc71

Parents:

cde999a

Message:

Wrap returns of errno from main() with EXIT_RC().

Returns of error code from main() prevent type checking when errno_t
and int are considered incompatible. In order to avoid the philosophical
discussion of what should and shouldn't be returned for main(), we simply
wrap the error values and leave the answer to the question for future
generations to decide.

File:

• uspace/srv/bd/sata_bd/sata_bd.c (modified) (4 diffs)

uspace/srv/bd/sata_bd/sata_bd.c

@@ -253 +253 @@
         if (rc != EOK) {
                 printf(NAME ": Unable to register driver: %s.\n", str_error(rc));
-                return rc;
+                return EXIT_RC(rc);
         }
         
         rc = get_sata_disks();
         if (rc != EOK) {
-                // TODO: log the error
-                return rc;
+                printf(NAME ": Cannot find SATA disks: %s.\n", str_error(rc));
+                return EXIT_RC(rc);
         }
 
@@ -265 +265 @@
         if (rc != EOK) {
                 printf("%s: Failed resolving category 'disk': %s.\n", NAME, str_error(rc));
-                return rc;
+                return EXIT_RC(rc);
         }
 
@@ -274 +274 @@
                 if (rc != EOK) {
                         printf(NAME ": Unable to register device %s: %s\n", name, str_error(rc));
-                        return rc;
+                        return EXIT_RC(rc);
                 }
 
@@ -281 +281 @@
                         printf("%s: Failed adding %s to category: %s.",
                             NAME, disk[i].dev_name, str_error(rc));
-                        return rc;
+                        return EXIT_RC(rc);
                 }
         }