Changeset 84a1a54 in mainline for uspace/app/nic/nic.c

Timestamp:

2018-01-04T20:47:53Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Children:

facacc71

Parents:

cde999a

Message:

Wrap returns of errno from main() with EXIT_RC().

Returns of error code from main() prevent type checking when errno_t
and int are considered incompatible. In order to avoid the philosophical
discussion of what should and shouldn't be returned for main(), we simply
wrap the error values and leave the answer to the question for future
generations to decide.

File:

• uspace/app/nic/nic.c (modified) (2 diffs)

uspace/app/nic/nic.c

@@ -413 +413 @@
         async_sess_t *sess;
         nic_address_t addr;
-        int rc, idx;
+        int rc;
+        int idx;
 
         sess = get_nic_by_index(i);
@@ -543 +544 @@
 
                 if (!str_cmp(argv[2], "addr"))
-                        return nic_set_addr(index, argv[3]);
+                        return EXIT_RC(nic_set_addr(index, argv[3]));
 
                 if (!str_cmp(argv[2], "speed"))
-                        return nic_set_speed(index, argv[3]);
+                        return EXIT_RC(nic_set_speed(index, argv[3]));
 
                 if (!str_cmp(argv[2], "duplex"))
-                        return nic_set_duplex(index, argv[3]);
+                        return EXIT_RC(nic_set_duplex(index, argv[3]));
 
                 if (!str_cmp(argv[2], "auto"))
-                        return nic_set_autoneg(index);
+                        return EXIT_RC(nic_set_autoneg(index));
 
                 if (!str_cmp(argv[2], "unicast"))
-                        return nic_set_rx_unicast(index, argv[3]);
+                        return EXIT_RC(nic_set_rx_unicast(index, argv[3]));
 
                 if (!str_cmp(argv[2], "multicast"))
-                        return nic_set_rx_multicast(index, argv[3]);
+                        return EXIT_RC(nic_set_rx_multicast(index, argv[3]));
 
                 if (!str_cmp(argv[2], "broadcast"))
-                        return nic_set_rx_broadcast(index, argv[3]);
+                        return EXIT_RC(nic_set_rx_broadcast(index, argv[3]));
 
         } else {