Changeset 800d188 in mainline for uspace/srv/bd/hr/raid1.c

Timestamp:

2025-04-15T07:00:31Z (4 weeks ago)

Author:

Miroslav Cimerman <mc@…>

Children:

29e7cc7

Parents:

ca7fa5b

git-author:

Miroslav Cimerman <mc@…> (2025-04-15 06:55:25)

git-committer:

Miroslav Cimerman <mc@…> (2025-04-15 07:00:31)

Message:

hr: metadata saving on stop

New bool argument for hr_metadata_save() to indicate if
we want callback too (on array stop we don't, so we won't
init a rebuild).

File:

• uspace/srv/bd/hr/raid1.c (modified) (6 diffs)

uspace/srv/bd/hr/raid1.c

@@ -105 +105 @@
         new_volume->hr_bds.sarg = new_volume;
 
+        new_volume->state_callback = hr_raid1_ext_state_callback;
+
         /* force volume state update */
         hr_mark_vol_state_dirty(new_volume);
@@ -222 +224 @@
         if (!atomic_compare_exchange_strong(&vol->state_dirty, &exp, false))
                 return;
+
+        fibril_mutex_lock(&vol->md_lock);
+
+        /* XXX: will be wrapped in md specific fcn ptrs */
+        vol->in_mem_md->counter++;
+
+        fibril_mutex_unlock(&vol->md_lock);
 
         fibril_rwlock_read_lock(&vol->extents_lock);
@@ -247 +256 @@
 
                 if (old_state != HR_VOL_REBUILD) {
+                        /* XXX: allow REBUILD on INVALID extents */
                         if (vol->hotspare_no > 0) {
                                 fid_t fib = fibril_create(hr_raid1_rebuild,
@@ -427 +437 @@
                         io->type = type;
                         io->vol = vol;
-                        io->state_callback = hr_raid1_ext_state_callback;
 
                         hr_fgroup_submit(group, hr_io_worker, io);
@@ -541 +550 @@
         fibril_rwlock_write_unlock(&vol->states_lock);
 
-        rc = hr_metadata_save(vol);
+        rc = hr_metadata_save(vol, WITH_STATE_CALLBACK);
 
 end:
@@ -576 +585 @@
         fibril_mutex_lock(&vol->hotspare_lock);
 
+        /* XXX: allow REBUILD on INVALID extents */
         if (vol->hotspare_no == 0) {
                 HR_WARN("hr_raid1_rebuild(): no free hotspares on \"%s\", "