Changeset 7c5320c in mainline for kernel/generic/src/console/chardev.c

Timestamp:

2023-02-07T16:03:05Z (2 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

master, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

1eaead4

Parents:

5110d0a

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2023-02-07 15:59:26)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2023-02-07 16:03:05)

Message:

Use the semaphore interface instead of waitq in some places

Since we already have an underused semaphore API in the kernel,
it would be worthwhile to use it in places where the baseline
semaphore semantics are needed. It makes the function of the
calls obvious even to people unfamiliar with the details of
waitq API.

File:

• kernel/generic/src/console/chardev.c (modified) (3 diffs)

kernel/generic/src/console/chardev.c

@@ -52 +52 @@
 {
         indev->name = name;
-        waitq_initialize(&indev->wq);
+        semaphore_initialize(&indev->wq, 0);
         irq_spinlock_initialize(&indev->lock, "chardev.indev.lock");
         indev->counter = 0;
@@ -81 +81 @@
         /* Index modulo size of buffer */
         indev->index = indev->index % INDEV_BUFLEN;
-        waitq_wakeup(&indev->wq, WAKEUP_FIRST);
+        semaphore_up(&indev->wq);
         irq_spinlock_unlock(&indev->lock, true);
 }
@@ -115 +115 @@
         }
 
-        waitq_sleep(&indev->wq);
+        semaphore_down(&indev->wq);
         irq_spinlock_lock(&indev->lock, true);
         char32_t ch = indev->buffer[(indev->index - indev->counter) %