Changeset 7473807 in mainline for kernel/generic/src/udebug/udebug_ops.c

Timestamp:

2018-05-11T20:22:42Z (7 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

d2c5159

Parents:

ae89656

Message:

Use atomic malloc allocations

We can safely use atomic allocations in places that use the non-failing
version of malloc(), but test the return value anyway. And also in some
places that can afford to return failure but did not because of comfort.

File:

• kernel/generic/src/udebug/udebug_ops.c (modified) (5 diffs)

kernel/generic/src/udebug/udebug_ops.c

@@ -370 +370 @@
 
         /* Allocate a buffer to hold thread IDs */
-        sysarg_t *id_buffer = malloc(buf_size + 1, 0);
+        sysarg_t *id_buffer = malloc(buf_size + 1, FRAME_ATOMIC);
+        if (!id_buffer)
+                return ENOMEM;
 
         mutex_lock(&TASK->udebug.lock);
@@ -432 +434 @@
         size_t name_size = str_size(TASK->name) + 1;
 
-        *data = malloc(name_size, 0);
+        *data = malloc(name_size, FRAME_ATOMIC);
+        if (!*data)
+                return ENOMEM;
         *data_size = name_size;
 
@@ -472 +476 @@
 
         /* Prepare a buffer to hold the arguments. */
-        sysarg_t *arg_buffer = malloc(6 * sizeof(sysarg_t), 0);
+        sysarg_t *arg_buffer = malloc(6 * sizeof(sysarg_t), FRAME_ATOMIC);
+        if (!arg_buffer) {
+                _thread_op_end(thread);
+                return ENOMEM;
+        }
 
         /* Copy to a local buffer before releasing the lock. */
@@ -514 +522 @@
 
         /* Prepare a buffer to hold the data. */
-        istate_t *state_buf = malloc(sizeof(istate_t), 0);
+        istate_t *state_buf = malloc(sizeof(istate_t), FRAME_ATOMIC);
+        if (!state_buf) {
+                _thread_op_end(thread);
+                return ENOMEM;
+        }
 
         /* Copy to the allocated buffer */
@@ -546 +558 @@
         }
 
-        void *data_buffer = malloc(n, 0);
+        void *data_buffer = malloc(n, FRAME_ATOMIC);
+        if (!data_buffer) {
+                mutex_unlock(&TASK->udebug.lock);
+                return ENOMEM;
+        }
 
         /*