Changeset 59fb782 in mainline for kernel/generic/src/mm/backend_phys.c

Timestamp:

2013-03-24T19:38:18Z (12 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

d965dc3

Parents:

119b46e

Message:

Unify the use of virtual addresses and virtual page addresses in mm code.

• as_page_fault() accepts faulting address (if available) and propagates the faulting page further along
• backends' page_fault() handlers assume page fault address
• page_mapping_create/destroy/find() accept addresses, but pass only page and frame addresses along
• as_area_create(), as_area_resize() now test whether the address is page-aligned
• renames of various variables to better fit their purpose (address vs. page)
• no need to align the addresses in mips32 TLB exception handlers now

File:

• kernel/generic/src/mm/backend_phys.c (modified) (3 diffs)

kernel/generic/src/mm/backend_phys.c

@@ -111 +111 @@
  *
  * @param area Pointer to the address space area.
- * @param addr Faulting virtual address.
+ * @param upage Faulting virtual page.
  * @param access Access mode that caused the fault (i.e. read/write/exec).
  *
@@ -117 +117 @@
  * serviced).
  */
-int phys_page_fault(as_area_t *area, uintptr_t addr, pf_access_t access)
+int phys_page_fault(as_area_t *area, uintptr_t upage, pf_access_t access)
 {
         uintptr_t base = area->backend_data.base;
@@ -123 +123 @@
         ASSERT(page_table_locked(AS));
         ASSERT(mutex_locked(&area->lock));
+        ASSERT(IS_ALIGNED(upage, PAGE_SIZE));
 
         if (!as_area_check_access(area, access))
                 return AS_PF_FAULT;
 
-        ASSERT(addr - area->base < area->backend_data.frames * FRAME_SIZE);
-        page_mapping_insert(AS, addr, base + (addr - area->base),
+        ASSERT(upage - area->base < area->backend_data.frames * FRAME_SIZE);
+        page_mapping_insert(AS, upage, base + (upage - area->base),
             as_area_get_flags(area));
         
-        if (!used_space_insert(area, ALIGN_DOWN(addr, PAGE_SIZE), 1))
+        if (!used_space_insert(area, upage, 1))
                 panic("Cannot insert used space.");