Changeset 4267908 in mainline for uspace/lib/usbhost/src/usb_device_manager.c

Timestamp:

2011-10-27T10:45:08Z (14 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

83c3123

Parents:

069b80d

Message:

libusbhost: Merge find_by_address and get_speed.

These functions were almost identical.
Clear handle on address release.

File:

• uspace/lib/usbhost/src/usb_device_manager.c (modified) (7 diffs)

uspace/lib/usbhost/src/usb_device_manager.c

@@ -38 +38 @@
 #include <usb/host/usb_device_manager.h>
 
-/*----------------------------------------------------------------------------*/
 /** Initialize device manager structure.
  *
@@ -77 +76 @@
                 ++new_address;
                 if (new_address > USB11_ADDRESS_MAX)
-                        new_address = 1;
+                        new_address = 1; // NOTE it should be safe to put 0 here
+                                         // TODO Use mod
                 if (new_address == instance->last_address) {
                         fibril_mutex_unlock(&instance->guard);
@@ -86 +86 @@
         assert(new_address != USB_ADDRESS_DEFAULT);
         assert(instance->devices[new_address].occupied == false);
+        assert(instance->devices[new_address].handle == 0);
 
         instance->devices[new_address].occupied = true;
@@ -131 +132 @@
 
         instance->devices[address].occupied = false;
+        instance->devices[address].handle = 0;
         fibril_mutex_unlock(&instance->guard);
 }
@@ -140 +142 @@
  * @return USB Address, or error code.
  */
-usb_address_t usb_device_manager_find(
+usb_address_t usb_device_manager_find_address(
     usb_device_manager_t *instance, devman_handle_t handle)
 {
@@ -157 +159 @@
         return ENOENT;
 }
-
-/** Find devman handle assigned to USB address.
- * Intentionally refuse to find handle of default address.
+/*----------------------------------------------------------------------------*/
+/** Find devman handle and speed assigned to USB address.
+ * Intentionally refuse to work on default address.
  *
  * @param[in] instance Device manager structure to use.
  * @param[in] address Address the caller wants to find.
  * @param[out] handle Where to store found handle.
- * @return Whether such address is currently occupied.
+ * @param[out] speed Assigned speed.
+ * @return Error code.
  */
-bool usb_device_manager_find_by_address(usb_device_manager_t *instance,
-    usb_address_t address, devman_handle_t *handle)
+int usb_device_manager_get_info_by_address(usb_device_manager_t *instance,
+    usb_address_t address, devman_handle_t *handle, usb_speed_t *speed)
 {
         assert(instance);
+        if ((address <= 0) || (address >= USB_ADDRESS_COUNT)) {
+                return EINVAL;
+        }
+
         fibril_mutex_lock(&instance->guard);
-        if ((address <= 0) || (address >= USB_ADDRESS_COUNT)) {
-                fibril_mutex_unlock(&instance->guard);
-                return false;
-        }
         if (!instance->devices[address].occupied) {
                 fibril_mutex_unlock(&instance->guard);
-                return false;
+                return ENOENT;
         }
 
@@ -183 +186 @@
                 *handle = instance->devices[address].handle;
         }
+        if (speed != NULL) {
+                *speed = instance->devices[address].speed;
+        }
 
         fibril_mutex_unlock(&instance->guard);
-        return true;
-}
-
-/*----------------------------------------------------------------------------*/
-/** Get speed associated with the address
- *
- * @param[in] instance Device manager structure to use.
- * @param[in] address Address of the device.
- * @return USB speed.
- */
-usb_speed_t usb_device_manager_get_speed(
-    usb_device_manager_t *instance, usb_address_t address)
-{
-        assert(instance);
-        assert(address >= 0);
-        assert(address <= USB11_ADDRESS_MAX);
-
-        return instance->devices[address].speed;
+        return EOK;
 }
 /**