Changeset 3f7e1f24 in mainline for uspace/srv/sysman/unit.c

Timestamp:

2019-08-03T08:28:26Z (6 years ago)

Author:

Matthieu Riolo <matthieu.riolo@…>

Children:

095d03c

Parents:

d7c5fc0

git-author:

Michal Koutný <xm.koutny+hos@…> (2015-04-22 17:54:08)

git-committer:

Matthieu Riolo <matthieu.riolo@…> (2019-08-03 08:28:26)

Message:

sysman: Refactored job manipulation (event loop + one main fibril)

File:

• uspace/srv/sysman/unit.c (modified) (2 diffs)

uspace/srv/sysman/unit.c

@@ -68 +68 @@
 
         unit->state = STATE_EMBRYO;
-        fibril_mutex_initialize(&unit->state_mtx);
-        fibril_condvar_initialize(&unit->state_cv);
 
         list_initialize(&unit->dependants);
@@ -105 +103 @@
 }
 
-void unit_set_state(unit_t *unit, unit_state_t state)
-{
-        fibril_mutex_lock(&unit->state_mtx);
-        unit->state = state;
-        fibril_condvar_broadcast(&unit->state_cv);
-        fibril_mutex_unlock(&unit->state_mtx);
-}
 
 /** Issue request to restarter to start a unit
  *
- * Return from this function only means start request was issued.
- * If you need to wait for real start of the unit, use waiting on state_cv.
+ * Ideally this function is non-blocking synchronous, however, some units
+ * cannot be started synchronously and thus return from this function generally
+ * means that start was requested.
+ *
+ * Check state of the unit for actual result, start method can end in states:
+ *   - STATE_STARTED, (succesful synchronous start)
+ *   - STATE_STARTING, (succesful asynchronous start request)
+ *   - STATE_FAILED.  (error occured)
  */
 int unit_start(unit_t *unit)