Changeset 3529f148 in mainline for uspace/srv/taskman/event.c

Timestamp:

2020-03-06T19:14:20Z (5 years ago)

Author:

Matthieu Riolo <matthieu.riolo@…>

Children:

13b4504

Parents:

06599a1

git-author:

Matthieu Riolo <matthieu.riolo@…> (2020-02-29 11:22:13)

git-committer:

Matthieu Riolo <matthieu.riolo@…> (2020-03-06 19:14:20)

Message:

Adding types task_wait_flag_t and ipc_start_flag_t which replaces makros

File:

• uspace/srv/taskman/event.c (modified) (7 diffs)

uspace/srv/taskman/event.c

@@ -50 +50 @@
         task_id_t waiter_id;  /**< Task ID who waits. */
         ipc_call_t *icall;  /**< Call ID waiting for the event. */
-        int flags;            /**< Wait flags. */
+        task_wait_flag_t flags; /**< Wait flags. */
 } pending_wait_t;
 
@@ -67 +67 @@
 }
 
-static int event_flags(task_t *task)
-{
-        int flags = 0;
+static task_wait_flag_t event_flags(task_t *task)
+{
+        task_wait_flag_t flags = TASK_WAIT_NONE;
         if (task->retval_type == RVAL_SET) {
                 flags |= TASK_WAIT_RETVAL;
@@ -88 +88 @@
 static void event_notify(task_t *sender, async_sess_t *sess)
 {
-        int flags = event_flags(sender);
-        if (flags == 0) {
+        task_wait_flag_t flags = event_flags(sender);
+        if (flags == TASK_WAIT_NONE) {
                 return;
         }
@@ -114 +114 @@
 static void event_notify_all(task_t *sender)
 {
-        int flags = event_flags(sender);
-        if (flags == 0) {
+        task_wait_flag_t flags = event_flags(sender);
+        if (flags == TASK_WAIT_NONE) {
                 return;
         }
@@ -140 +140 @@
                         continue; // TODO really when does this happen?
                 }
-                int notify_flags = event_flags(t);
+                task_wait_flag_t notify_flags = event_flags(t);
 
                 /*
@@ -146 +146 @@
                  * thus it can be never present in rest flags.
                  */
-                int rest = (~notify_flags & pr->flags) & ~TASK_WAIT_RETVAL;
+                task_wait_flag_t rest = (~notify_flags & pr->flags) & ~TASK_WAIT_RETVAL;
                 rest &= ~TASK_WAIT_BOTH;
-                int match = notify_flags & pr->flags;
+                bool match = notify_flags & pr->flags;
                 // TODO why do I even accept such calls?
                 bool answer = !(pr->icall->flags & IPC_CALL_NOTIF);
@@ -233 +233 @@
 }
 
-void wait_for_task(task_id_t id, int flags, ipc_call_t *icall,
+void wait_for_task(task_id_t id, task_wait_flag_t flags, ipc_call_t *icall,
     task_id_t waiter_id)
 {