Changeset 293de44 in mainline for uspace/drv/uhci-hcd/transfer_list.c

Timestamp:

2011-05-20T11:18:53Z (14 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

c7c2443

Parents:

160b75e (diff), 7941bd6 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge development/ changes

File:

• uspace/drv/uhci-hcd/transfer_list.c (modified) (4 diffs)

uspace/drv/uhci-hcd/transfer_list.c

@@ -34 +34 @@
 #include <errno.h>
 #include <usb/debug.h>
+#include <arch/barrier.h>
 
 #include "transfer_list.h"
@@ -71 +72 @@
  * @param[in] instance Memory place to use.
  *
- * Frees memory for internal qh_t structure.
+ * Frees memory of the internal qh_t structure.
  */
 void transfer_list_fini(transfer_list_t *instance)
@@ -126 +127 @@
         assert((pa & LINK_POINTER_ADDRESS_MASK) == pa);
 
+        /* Make sure all data in the batch are written */
+        write_barrier();
+
         /* keep link */
         batch_qh(batch)->next = last_qh->next;
         qh_set_next_qh(last_qh, batch_qh(batch));
 
-        asm volatile ("": : :"memory");
+        /* Make sure the pointer is updated */
+        write_barrier();
 
         /* Add to the driver list */
@@ -222 +227 @@
             == addr_to_phys(batch_qh(batch)));
         prev_qh->next = batch_qh(batch)->next;
-        asm volatile ("": : :"memory");
+
+        /* Make sure the pointer is updated */
+        write_barrier();
+
         /* Remove from the batch list */
         list_remove(&batch->link);