Changeset 1d758fc in mainline for uspace/drv/bus/usb/xhci/endpoint.c

Timestamp:

2018-02-12T10:11:47Z (7 years ago)

Author:

Ondřej Hlavatý <aearsis@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

5fe3f954

Parents:

2f762a7

git-author:

Ondřej Hlavatý <aearsis@…> (2018-02-05 03:28:50)

git-committer:

Ondřej Hlavatý <aearsis@…> (2018-02-12 10:11:47)

Message:

usb: rethinking DMA buffers

File:

• uspace/drv/bus/usb/xhci/endpoint.c (modified) (1 diff)

uspace/drv/bus/usb/xhci/endpoint.c

@@ -116 +116 @@
                 goto err;
 
-        /* Driver can handle non-contiguous buffers */
-        ep->transfer_buffer_policy &= ~DMA_POLICY_CONTIGUOUS;
-
-        /* Driver can handle buffers crossing boundaries */
-        ep->transfer_buffer_policy &= ~DMA_POLICY_NOT_CROSSING;
+        unsigned flags = -1U;
 
         /* Some xHCs can handle 64-bit addresses */
         xhci_bus_t *bus = bus_to_xhci_bus(ep->device->bus);
         if (bus->hc->ac64)
-                ep->transfer_buffer_policy &= ~DMA_POLICY_4GiB;
+                flags &= ~DMA_POLICY_4GiB;
+
+        /* xHCI works best if it can fit 65k transfers in one TRB */
+        ep->transfer_buffer_policy = dma_policy_create(flags, 1 << 16);
+
+        /* But actualy can do full scatter-gather. */
+        ep->required_transfer_buffer_policy = dma_policy_create(flags, PAGE_SIZE);
 
         return EOK;