Changeset 1871118 in mainline for kernel/generic/src/proc/task.c

Timestamp:

2023-02-10T22:59:11Z (2 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

master, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

11d2c983

Parents:

daadfa6

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2023-02-10 22:53:12)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2023-02-10 22:59:11)

Message:

Make thread_t reference counted

This simplifies interaction between various locks and thread
lifespan, which simplifies things. For example, threads_lock can
now simply be a mutex protecting the global it was made for, and
nothing more.

File:

• kernel/generic/src/proc/task.c (modified) (3 diffs)

kernel/generic/src/proc/task.c

@@ -385 +385 @@
         irq_spinlock_lock(&tasks_lock, true);
         irq_spinlock_lock(&TASK->lock, false);
-        irq_spinlock_lock(&threads_lock, false);
 
         /* Set task name */
         str_cpy(TASK->name, TASK_NAME_BUFLEN, namebuf);
 
-        irq_spinlock_unlock(&threads_lock, false);
         irq_spinlock_unlock(&TASK->lock, false);
         irq_spinlock_unlock(&tasks_lock, true);
@@ -529 +527 @@
 {
         irq_spinlock_lock(&task->lock, false);
-        irq_spinlock_lock(&threads_lock, false);
 
         /*
@@ -536 +533 @@
 
         list_foreach(task->threads, th_link, thread_t, thread) {
-                thread_interrupt(thread, false);
+                thread_t *thr = thread_try_ref(thread);
+                if (thr)
+                        thread_interrupt(thr, false);
+
+                // If NULL, the thread is already getting destroyed concurrently with this.
         }
 
-        irq_spinlock_unlock(&threads_lock, false);
         irq_spinlock_unlock(&task->lock, false);
 }